OSX: Download JRE with Maven to bundle it into 'Playforia Minigolf Client.app' #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
reviewed
Sep 6, 2020
client/pom.xml
Outdated
| @@ -16,6 +16,9 @@ | |||
| <properties> | |||
| <project.mainClass>org.moparforia.client.Launcher</project.mainClass> | |||
| <project.name>Playforia Minigolf Client</project.name> | |||
| <project.downloadDir>${basedir}/../downloads</project.downloadDir> | |||
| <project.jreLinkOSX>https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u252-b09.1/OpenJDK8U-jre_x64_mac_hotspot_8u252b09.tar.gz</project.jreLinkOSX> | |||
| <project.jreNameOSX>jdk8u252-b09-jre</project.jreNameOSX> | |||
There was a problem hiding this comment.
I would change the property name to something like <project.jre.osx.name>
PhilippvK
force-pushed
the
osx-dl-jre
branch
from
308801e
to
18f30d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you have a better idea for which Maven phase should be used to trigger the download, please let me know.
mvn deploydid not work for me on on the other hand sounds a bit counter intuitive.See #45