More deobfuscation #107
Merged
More deobfuscation #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These arrays are only written to, never read. This looks like a performance optimization to avoid string allocation at run-time as these arrays are otherwise unused. These kinds of optimizations are not needed on modern hardware, they just make the code structure more complicated.
This revealed that the `anInt997` field was unused and could be removed.
Looks like the server never sends track score multipliers currently. Nevertheless, this is code is nice to deobfuscate to better understand surrounding code.
These are some small changes that did not really fit in with other commits.
This is easier to understand than a double negative. No functional changes.
This class works in a similar way to SoundManager, it contains a map for localization strings that are specific to Minigolf as well as a map for strings that were shared between multiple Playforia games. As part of this I renamed Class89 -> LocalizationNode which represents an XML node containing translations for a single entry.
This more accurately reflects what the code does. The return value was never used so I also changed the method to return void. Since get_upd() without any parameters was just adding 1 to the internal integer, I removed the method to simplify the class; now when 1 needs to be added to the internal int, add(1) can be called.
This also includes removing the iterative modifying of the offsetY (now renamed to yBaseline) variable for drawing player info, instead it can be calculated in the loop based on the index variable.
These are drive-by fixes while debugging an issue, no functional changes. Highlight: renaming PacketHandlerFactoryGeneratorClassHelperImplementationDecorator -> PacketHandlerFactory. Looks like the original implementor was having fun with design pattern names.
PhilippvK
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no functional changes in this PR, only cosmetic ones. Most renamings were done with IntelliJ's refactoring functionality. See individual commits for more details.
After merging this, I have some changes ready that actually add features and fix some bugs, but I wanted to keep those separate to make them easier to review.