Delete unused code from com.aapeli package #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletes ~7400 lines of unused code, making the project easier to reason about and develop. Almost all of these classes are never referenced in code accessible by the minigolf client, with two exceptions: - Product is referenced in AApplet.java in some methods that are never called; these methods were also removed - AutoPopups.java references Class85, however the field storing an instance is never initialized so it's always null. This field was removed.
PhilippvK
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes ~7400 lines of unused code, making the project easier to reason about and develop. Almost all of these classes are never referenced in code accessible by the minigolf client, with two exceptions: