Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Track handling #61

Closed
pehala opened this issue Oct 11, 2020 · 11 comments · Fixed by #65
Closed

Rewrite Track handling #61

pehala opened this issue Oct 11, 2020 · 11 comments · Fixed by #65
Assignees

Comments

@pehala
Copy link
Collaborator

pehala commented Oct 11, 2020

As part of #37, I would like to rewrite how the Tracks and Stats work.

This issue is to track (no pun intended) discussions surrounding this topic.

@pehala pehala self-assigned this Oct 11, 2020
@pehala
Copy link
Collaborator Author

pehala commented Oct 11, 2020

Part of the rewrite is separate Track statistics into their own class. I have extracted this but to be honest, I don't understand all of the statistics that are currently in use (or were on Playforia).

public class TrackStats {

    private Track track;

    private int totalNumberOfAttempts;

    private int totalStrokes;

    private int bestPar;

    private int numberOfBestPar;


    private String firstBestPlayer;

    private long firstBestTime;

    private String lastBestPlayer;

    private long lastBestTime;

    private int[] ratings;
}

I am not sure about the use case for lastBestPlayer, firstBestTime, lastBestTime, are they used somewhere in the UI? Also are there any more statistics you want to track?
@PhilippvK

@PhilippvK
Copy link
Owner

The UI on Playforia had shown the first player who scored the highscore in all time the the last player who was able to finish the same number of strokes. If I remember correctly...

No need to show something else, the UI is already overloaded but if you or anyone else has a good idea, feel free to implement it.

@pehala
Copy link
Collaborator Author

pehala commented Oct 11, 2020

Does it still show in this version? There is best stroke and by who, but I do not know if it also shows the lastPlayer who scored it.

@PhilippvK
Copy link
Owner

image

I have not checked the current version of the game as I am currently not on my computer but this is what I found on Google. Its in German, but there are also screenshots in other languages.

I can see 2 different usernames and timestamps there. To be honest, I would not have anything against getting rid of one of them.

@pehala
Copy link
Collaborator Author

pehala commented Oct 11, 2020

Thanks! I will remove the lastPlayer then, only fastest deserve the glory :D

@PhilippvK
Copy link
Owner

One thing which would be great, is allow resetting the highscores of all tracks in a easy way. Most of the highscores are unrealistic because they have been achieved using the aimbot (See #62), so the efforts in reenabling the highscore database would be quite useless as the score can not be beaten anymore.

@pehala
Copy link
Collaborator Author

pehala commented Oct 11, 2020

Current plan is to start with blank database as default, but providing option to import scores from the files. In this case we dont have to do anything to reset it.

@pehala
Copy link
Collaborator Author

pehala commented Oct 11, 2020

Another question, do we want to allow rating once per user, or once per game?

@PhilippvK
Copy link
Owner

I do not mind very much. Once per user seems to be more realistic but could be harder to handle, especially as there is no user-database.

@pehala
Copy link
Collaborator Author

pehala commented Oct 12, 2020

We also have bestTime parameter, which I guess should be date instead?

@PhilippvK
Copy link
Owner

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants