Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat message visibility issue #57

Closed
flying-aces-hb opened this issue Sep 29, 2020 · 2 comments
Closed

Chat message visibility issue #57

flying-aces-hb opened this issue Sep 29, 2020 · 2 comments

Comments

@flying-aces-hb
Copy link

Hello,

when we are playing, the ingame chat (working fine in the lobby) seems broken in that not all other player's messages are displayed. E.g. player A and player B can see what each other write, and player A can see player C but not the other way around, while B can't see C and D can't see anyone else. This is just an example, who can see whom seems random and inconsistent.

Is this a known issue? Sorry if my description is convoluted, I couldn't think of a simpler way of describing the problem.

@PhilippvK
Copy link
Owner

As the server reimplementation is written in a highly unreliable way, there are many similar issues regarding chat, timing,... which are not easy to fix without throwing away everything and starting from scratch.

The buggy connection was partly covered here and I spend some time debugging and I temporarily inserted synchronized code section unfortunately without success:

#29

Any information which could help to find the exact code parts which are causing the chat issue would be very helpful.

@PhilippvK
Copy link
Owner

Yey, I found that silly chat bug.

The foreach loop for iterating over every player had a break statement in it.

I will push the fix later!

PhilippvK added a commit that referenced this issue Oct 3, 2020
PhilippvK added a commit that referenced this issue Oct 4, 2020
Fix chat visibility problem (See #57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants