[#2941] Implement script score query #2942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the script score query to fix Philippus#2941. For now the ScriptScoreQueryBodyFn2 class has the terrible name because I suspect that the current ScriptScoreQueryBodyFn is never exercised. The ScriptScore that it accepts isn't actually a query, so will never hit the pattern match?
sam-briggs-depop
force-pushed
the
2941/implement-script-score-query
branch
from
55d6f67 to
6b523f1
Compare
added 2 commits
October 25, 2023 18:28
From inspection I suspect this case would never be hit, because ScriptScore doesn't implement the Query trait. This was the only call site for ScriptScoreQueryBodyFn (which has an odd name, given it accepted a ScriptScore and not a ScriptScoreQuery). Therefore I've removed it, and put the ScriptScoreQueryBodyFn2 in its place
TODO: this test is failing currently
elastic4s-tests/src/test/scala/com/sksamuel/elastic4s/search/queries/ScriptScoreQueryTest.scala
Show resolved
Hide resolved
|
The PR is still in draft. If it's ready, bar that other test, please move to ready state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the script score query to fix #2941.
For now the ScriptScoreQueryBodyFn2 class has the terrible name because
I suspect that the current ScriptScoreQueryBodyFn is never exercised.
The ScriptScore that it accepts isn't actually a query, so will never
hit the pattern match?