Skip to content

Commit

Permalink
[Security Solution][Alert Details] - remove flyout tour introduced in…
Browse files Browse the repository at this point in the history
… 8.14 (elastic#198708)

## Summary

We [added](elastic#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve elastic#197492

(cherry picked from commit 0aec5a8)

# Conflicts:
#	x-pack/packages/security-solution/common/src/flyout/common/components/flyout_navigation.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/shared/utils/tour_step_config.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
  • Loading branch information
PhilippeOberti committed Nov 4, 2024
1 parent a669b6c commit 9b995ec
Show file tree
Hide file tree
Showing 22 changed files with 14 additions and 945 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
HEADER_ACTIONS_TEST_ID,
COLLAPSE_DETAILS_BUTTON_TEST_ID,
EXPAND_DETAILS_BUTTON_TEST_ID,
HEADER_NAVIGATION_BUTTON_TEST_ID,
} from '../test_ids';

export interface FlyoutNavigationProps {
Expand Down Expand Up @@ -116,7 +115,7 @@ export const FlyoutNavigation: FC<FlyoutNavigationProps> = memo(
height: ${euiTheme.size.xxl};
`}
>
<EuiFlexItem grow={false} data-test-subj={HEADER_NAVIGATION_BUTTON_TEST_ID}>
<EuiFlexItem grow={false}>
{flyoutIsExpandable && expandDetails && (isExpanded ? collapseButton : expandButton)}
</EuiFlexItem>
{actions && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const EXPANDABLE_PANEL_CONTENT_TEST_ID = (dataTestSubj: string) => `${dat
/* Header Navigation */

const FLYOUT_NAVIGATION_TEST_ID = `${PREFIX}Navigation` as const;
export const HEADER_NAVIGATION_BUTTON_TEST_ID = `${PREFIX}NavigationButton` as const;
export const EXPAND_DETAILS_BUTTON_TEST_ID =
`${FLYOUT_NAVIGATION_TEST_ID}ExpandDetailButton` as const;
export const COLLAPSE_DETAILS_BUTTON_TEST_ID =
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/fleet/cypress/tasks/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export const internalRequest = <T = unknown>({
const NEW_FEATURES_TOUR_STORAGE_KEYS = {
RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.9',
TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
};

const disableNewFeaturesTours = (window: Window) => {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/osquery/cypress/tasks/navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ export enum NAV_SEARCH_INPUT_OSQUERY_RESULTS {
export const NEW_FEATURES_TOUR_STORAGE_KEYS = {
RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.13',
TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
TIMELINE: 'securitySolution.timeline.newFeaturesTour.v8.12',
FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
KNOWLEDGE_BASE: 'elasticAssistant.knowledgeBase.newFeaturesTour.v8.16',
};

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/security_solution/common/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,6 @@ export const RULES_TABLE_MAX_PAGE_SIZE = 100;
export const NEW_FEATURES_TOUR_STORAGE_KEYS = {
RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.13',
TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
};

export const RULE_DETAILS_EXECUTION_LOG_TABLE_SHOW_METRIC_COLUMNS_STORAGE_KEY =
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { getField } from '../shared/utils';
import { EventKind } from '../shared/constants/event_kinds';
import { useDocumentDetailsContext } from '../shared/context';
import type { DocumentDetailsProps } from '../shared/types';
import { LeftPanelTour } from './components/tour';

export type LeftPanelPaths = 'visualize' | 'insights' | 'investigation' | 'response' | 'notes';
export const LeftPanelVisualizeTab: LeftPanelPaths = 'visualize';
Expand Down Expand Up @@ -85,7 +84,6 @@ export const LeftPanel: FC<Partial<DocumentDetailsProps>> = memo(({ path }) => {

return (
<>
<LeftPanelTour />
<PanelHeader
selectedTabId={selectedTabId}
setSelectedTabId={setSelectedTabId}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ import { useExpandableFlyoutApi, useExpandableFlyoutState } from '@kbn/expandabl
import { useKibana } from '../../../../common/lib/kibana';
import {
INSIGHTS_TAB_BUTTON_GROUP_TEST_ID,
INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID,
INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID,
INSIGHTS_TAB_THREAT_INTELLIGENCE_BUTTON_TEST_ID,
INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID,
INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID,
INSIGHTS_TAB_CORRELATIONS_BUTTON_TEST_ID,
} from './test_ids';
Expand All @@ -40,12 +38,10 @@ const insightsButtons: EuiButtonGroupOptionProps[] = [
{
id: ENTITIES_TAB_ID,
label: (
<div data-test-subj={INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID}>
<FormattedMessage
id="xpack.securitySolution.flyout.left.insights.entitiesButtonLabel"
defaultMessage="Entities"
/>
</div>
<FormattedMessage
id="xpack.securitySolution.flyout.left.insights.entitiesButtonLabel"
defaultMessage="Entities"
/>
),
'data-test-subj': INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID,
},
Expand All @@ -62,12 +58,10 @@ const insightsButtons: EuiButtonGroupOptionProps[] = [
{
id: PREVALENCE_TAB_ID,
label: (
<div data-test-subj={INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID}>
<FormattedMessage
id="xpack.securitySolution.flyout.left.insights.prevalenceButtonLabel"
defaultMessage="Prevalence"
/>
</div>
<FormattedMessage
id="xpack.securitySolution.flyout.left.insights.prevalenceButtonLabel"
defaultMessage="Prevalence"
/>
),
'data-test-subj': INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,8 @@ const INSIGHTS_TAB_TEST_ID = `${PREFIX}InsightsTab` as const;
export const INSIGHTS_TAB_BUTTON_GROUP_TEST_ID = `${INSIGHTS_TAB_TEST_ID}ButtonGroup` as const;
export const INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID =
`${INSIGHTS_TAB_TEST_ID}EntitiesButton` as const;
export const INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID =
`${INSIGHTS_TAB_TEST_ID}Entities` as const;
export const INSIGHTS_TAB_THREAT_INTELLIGENCE_BUTTON_TEST_ID =
`${INSIGHTS_TAB_TEST_ID}ThreatIntelligenceButton` as const;
export const INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID =
`${INSIGHTS_TAB_TEST_ID}Prevalence` as const;
export const INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID =
`${INSIGHTS_TAB_TEST_ID}PrevalenceButton` as const;
export const INSIGHTS_TAB_CORRELATIONS_BUTTON_TEST_ID =
Expand Down
Loading

0 comments on commit 9b995ec

Please sign in to comment.