Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node from 14 to 16 #81

Closed
joaoluis-pdm opened this issue Jun 1, 2022 · 3 comments
Closed

Upgrade node from 14 to 16 #81

joaoluis-pdm opened this issue Jun 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@joaoluis-pdm
Copy link
Contributor

As node 14 has no longer active maintenance fixes, FGT image should upgrade from 14 to 16.
See also #74 (comment)

@joaoluis-pdm joaoluis-pdm added the enhancement New feature or request label Jun 1, 2022
@joaoluis-pdm joaoluis-pdm self-assigned this Jun 1, 2022
@joaoluis-pdm
Copy link
Contributor Author

Trying node v16.14.2.
The first problem appears during npm install:

jpsl@PDM-00781:/export/home/jpsl/develop/PharmaLedger/fgt-workspace$ npm i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '~14', npm: '~6' },
npm WARN EBADENGINE   current: { node: 'v16.14.2', npm: '8.5.0' }
npm WARN EBADENGINE }
npm WARN deprecated [email protected]: This module is no longer maintained, try this instead:
npm WARN deprecated   npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.
...

@joaoluis-pdm
Copy link
Contributor Author

The push to master change in octopus-freeze.json above are required to test the build of docker images from git master.

@joaoluis-pdm
Copy link
Contributor Author

Tests by running

node --unhandled-rejections=strict wsCreateStuff.js --sleep=80000

on a local docker-compose succeed. The upgrade to node 16 should be considered complete and closed, and available for the next release.

joaoluis-pdm added a commit that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant