-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Polkadot v0.9.37 #249
Conversation
9a5aaf4
to
d0c1bec
Compare
Re. tx version: Let's check how tx version affects the blockchain behavior in substrate. If it's only for external signer (e.g. hardware or mobile wallet) to distinguish changes in extrinsic args, we'd rather just keep it as is. However, if it affects the security of the blockchain, we have no choice but update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go through the pallet-assets and SubBridge relevant changes, LGTM
af02797
to
d759132
Compare
Bump runtimes’ spec to 1209
66382ca
to
a4b090d
Compare
# Conflicts: # runtime/khala/src/lib.rs # runtime/rhala/src/lib.rs # runtime/thala/src/lib.rs
I shall merge this, feel free to double check it |
@@ -62,7 +62,6 @@ pub mod messaging { | |||
|
|||
#[derive(Encode, Decode, Debug, TypeInfo)] | |||
pub struct WorkerInfo { | |||
pub attestation_provider: Option<AttestationProvider>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember how it was changed? This message is sent from the pallet to the worker. If the definition is changed, the existing pruntime may not answer properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kevin says this removing is correct, or it will be problem for PRuntime V2
Because of Cumulus not released 0.9.34 and 0.9.35 so we upgrade from 0.9.33 to 0.9.37
https://github.com/paritytech/polkadot/releases/tag/v0.9.34
https://github.com/paritytech/polkadot/releases/tag/v0.9.35
https://github.com/paritytech/polkadot/releases/tag/v0.9.36
https://github.com/paritytech/polkadot/releases/tag/v0.9.37
paritytech/substrate@polkadot-v0.9.33...polkadot-v0.9.34
paritytech/substrate@polkadot-v0.9.34...polkadot-v0.9.35
paritytech/substrate@polkadot-v0.9.35...polkadot-v0.9.36
paritytech/substrate@polkadot-v0.9.36...polkadot-v0.9.37
Breaking changes:
Notable changes:
EnsureOriginOrHigherPrivilege
paritytech/substrate#12844RuntimeVersion
of overwritten/substituted wasm binary paritytech/substrate#13066In addition:
Because of we need to run migrations for assets and balances in this version, I think we should upgrade Phala parachain as well
We need test migration carefully
TODO:--state-pruning
issue