[Project] Only ship ESM (#39)

Pewtro · Oct 29, 2024 · 2d2e2c1 · 2d2e2c1
1 parent f51a4fb
commit 2d2e2c1
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 46 deletions.
diff --git a/.changeset/quick-rice-give.md b/.changeset/quick-rice-give.md
@@ -0,0 +1,11 @@
+---
+'@blizzard-api/classic-wow': major
+'@blizzard-api/client': major
+'@blizzard-api/core': major
+'@blizzard-api/d3': major
+'@blizzard-api/hs': major
+'@blizzard-api/sc2': major
+'@blizzard-api/wow': major
+---
+
+This package now ships with ESM-only. If you need ESM and CJS you can use the previous major release that was a dual-release. Node v22 also ships with native interoperability between the two that you can utilise
diff --git a/package.json b/package.json
@@ -62,10 +62,10 @@
     "typecheck": "tsc"
   },
   "lint-staged": {
-    "*.{ts,tsx,js,jsx,cjs,mjs,md,mdx,yaml,yml,json}": [
+    "*.{ts,tsx,js,jsx,mjs,md,mdx,yaml,yml,json}": [
       "prettier --write"
     ],
-    "*.{ts,tsx,js,jsx,cjs,mjs}": [
+    "*.{ts,tsx,js,jsx,mjs}": [
       "pnpm --silent lint:fix"
     ]
   }

diff --git a/packages/classic-wow/package.json b/packages/classic-wow/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/classic-wow-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/classic-wow-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/client/package.json b/packages/client/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/client-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/client-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/core-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/core-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/d3/package.json b/packages/d3/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/d3-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/d3-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/hs/package.json b/packages/hs/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/hs-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/hs-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/sc2/package.json b/packages/sc2/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/sc2-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/sc2-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/packages/wow/package.json b/packages/wow/package.json
@@ -9,19 +9,13 @@
   "engines": {
     "node": "^18.18 || >=20.9"
   },
-  "main": "./dist/index.cjs",
   "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
       "@blizzard-api/wow-local": "./src/index.ts",
       "types": "./dist/index.d.ts",
       "default": "./dist/index.js"
-    },
-    "require": {
-      "@blizzard-api/wow-local": "./src/index.ts",
-      "types": "./dist/index.d.cts",
-      "default": "./dist/index.cjs"
     }
   },
   "files": [

diff --git a/tsup.config.ts b/tsup.config.ts
@@ -7,7 +7,7 @@ export default defineConfig(({ watch = false }) => ({
     index: './src/index.ts',
   },
   external: [],
-  format: ['cjs', 'esm'],
+  format: 'esm',
   outDir: 'dist',
   sourcemap: true,
   treeshake: true,

diff --git a/vitest.config.ts b/vitest.config.ts
@@ -19,7 +19,6 @@ export default defineConfig({
         //There's no reason to test the index files as they are just exporting what is already tested
         '**/index.ts',
         //Ignore the config files
-        '**/.eslintrc.cjs',
         '**/.prettierrc.js',
         '**/vitest.workspace.ts',
       ],