Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timer with coroutine for output plugins - AWS Distro rebase #26

Open
wants to merge 2 commits into
base: 2_31_10_all_cherry_picks
Choose a base branch
from

Conversation

PettitWesley
Copy link
Owner


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@PettitWesley PettitWesley temporarily deployed to pr July 9, 2023 23:28 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr July 10, 2023 05:58 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr July 13, 2023 17:54 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 4, 2023 04:20 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 4, 2023 19:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 04:51 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 05:48 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 05:51 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 05:51 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:03 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:12 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:13 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 5, 2023 06:42 — with GitHub Actions Inactive
@PettitWesley PettitWesley force-pushed the coroutine-timer-aws-distro branch from 8b9bd6e to 2f92c31 Compare September 11, 2023 01:06
@PettitWesley PettitWesley temporarily deployed to pr September 11, 2023 01:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 11, 2023 01:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 11, 2023 01:06 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr September 11, 2023 01:29 — with GitHub Actions Inactive
mk_list_foreach_safe(head, tmp, timer_coro_list) {
timer_coro = mk_list_entry(head, struct flb_output_timer_coro, _head);
if (timer_coro != NULL) {
flb_info("[task] output=%s still running %d %s(s)",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is this will say "output=s3.1 still running 1 Upload(s)"

It won't actually be accurate tho it looks nice. A timer coroutine is not the same as an upload, each one could send many uploads.

Each timer coro is just a thread/helper to peform uploads.

I can't think of a better word to use here tho.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant