out_s3: fix use-after-free in destructor

Signed-off-by: Jesse Rittner <[email protected]>
PettitWesley · Jul 10, 2021 · ab4cf8b · ab4cf8b
1 parent bd0a80b
commit ab4cf8b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/plugins/out_s3/s3.c b/plugins/out_s3/s3.c
@@ -307,14 +307,14 @@ static void s3_context_destroy(struct flb_s3 *ctx)
         flb_tls_destroy(ctx->sts_provider_tls);
     }
 
-    if (ctx->client_tls) {
-        flb_tls_destroy(ctx->client_tls);
-    }
-
     if (ctx->s3_client) {
         flb_aws_client_destroy(ctx->s3_client);
     }
 
+    if (ctx->client_tls) {
+        flb_tls_destroy(ctx->client_tls);
+    }
+
     if (ctx->free_endpoint == FLB_TRUE) {
         flb_free(ctx->endpoint);
     }