Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstractrhs #16

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Abstractrhs #16

merged 5 commits into from
Jan 10, 2023

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Jan 10, 2023

  • allow to use AbstractVector instances as right hand sides (so it can run on views etc)
  • Add factorize flag to sparspaklu to play nice with LinearSolve.jl
  • Add docs for sparspaklu to functions section, and some remark on generic FP in Home

@j-fu j-fu mentioned this pull request Jan 10, 2023
Merged
@PetrKryslUCSD PetrKryslUCSD merged commit 3276f37 into PetrKryslUCSD:main Jan 10, 2023
@j-fu
Copy link
Contributor Author

j-fu commented Jan 10, 2023

Hi, thanks, great! Could you tag a release for this ?
And may be once you edit Project.toml, there is still a glitch in the code (without influence on performance/functionality): This line and the following should be deleted...

@j-fu
Copy link
Contributor Author

j-fu commented Jan 10, 2023

Thanks !- This appears to work well now with LinearSolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-fu @PetrKryslUCSD