Fix GetGizmos Performance #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetGizmos() Postfix was causing some lag spikes in my game (see screenshot) when a pawn was selected. The reason for this is because with the Simple Sidearms code, the game has to evaluate all of a pawn's gizmos and create a new List() with those Gizmos.
This update to the postfix changes that behavior so that the Simple Sidearms gizmo is added to the existing list, without evaluating the contents of the Gizmo List (which is the expensive part). See below screenshots for comparison.
Before:
After:
