Do not ignore non-zero error code from 'make minitest'

[jkeenan]

In pipelines like:

$ sh ./Configure -des -Dusedevel && \
    make minitest && make test_harness

... we don't want to run 'make test_harness' unless 'make minitest' has
succeeded.

To test:

$ echo "exit(1);" >> t/base/cond.t
$ make minitest && echo "hello world"
# [note that minitest fails quickly and 'echo' is not reached]

$ git checkout -- t/base/cond.t
$ make minitest && echo "hello world"
# [note that minitest runs and 'echo' is reached]

For: 16160
Originally: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132139

[doughera88]

On Thu, Jan 30, 2020 at 07:32:53PM -0800, James E Keenan wrote: @jkeenan requested your review on: Perl/perl5#17510 Do not ignore non-zero error code from 'make minitest'.

I agree we shouldn't ignore the non-zero error code. Thanks for spotting this and following up.

…

-- Andy Dougherty [email protected]

-- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: #17510 (comment)