Updated access control for methods in JSONConvertibleObject #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be open so that they can be overwritten
|
|
iamjono
added a commit
to iamjono/Perfect
that referenced
this pull request
Feb 1, 2017
Updated access control for methods in JSONConvertibleObject Former-commit-id: 30323ad Former-commit-id: 6cea2aaa092667ac383919ff10b61e7c91fd183c Former-commit-id: ab9d7a259b2a2fcc39f6e2115a545deae8ac80bc Former-commit-id: b180058f72ed59eb31feb5e8b679886231d03800
iamjono
added a commit
that referenced
this pull request
Feb 1, 2017
Updated access control for methods in JSONConvertibleObject Former-commit-id: 30323ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated JSON methods in JSONConvertibleObject to be
openso that they can be overwritten by subclasses.A corresponding jira bug has also been created:
http://jira.perfect.org:8080/browse/ISS-255