refactor dynamic loader class to look more like Swift #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if else with guard else, where possible
iamjono
pushed a commit
to iamjono/Perfect
that referenced
this pull request
Feb 1, 2017
…loader refactor dynamic loader class to look more like Swift Former-commit-id: 7add841 Former-commit-id: e31da436c4ab0d35fb1c79fd92de0365d0726967 Former-commit-id: f5f8e1e4aef44d02d4151e7a94435ac7825c3c18 Former-commit-id: bf830264b98e24add72c7661993360fd3a199c44
iamjono
pushed a commit
that referenced
this pull request
Feb 1, 2017
refactor dynamic loader class to look more like Swift Former-commit-id: 7add841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dynamic loader class to look more like Swift using guard else instead of if else where appropriate. It makes code bit clean and comfortable to read as now there are fewer blocks.