Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found issue with async methods and fixed it #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sofbix
Copy link

@sofbix sofbix commented Dec 26, 2018

async method was wrong and my app had deadlock, I fixed it with api method

@RockfordWei
Copy link
Collaborator

Nice work! Could you please add some tests to the script?

@RockfordWei
Copy link
Collaborator

Hi, please note that Swift 5 will no longer support SPM 3 module format, so all system libraries would be merged and became independent. Would you like to change them in Package.swift? Or I have to close this PR and reopen it when ready.

@sofbix
Copy link
Author

sofbix commented Mar 30, 2019

Last commit shouldn't get to this pull request. You can close it. And I can make test for async method. Sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants