Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforcing url encode for api requests #2

Merged
merged 1 commit into from
Jun 26, 2018
Merged

enforcing url encode for api requests #2

merged 1 commit into from
Jun 26, 2018

Conversation

RockfordWei
Copy link
Contributor

NOTE the original for loop didn't change the key ordering nature of dictionary [:] so this url encoded version implementation is applying map/reduce.

@RockfordWei
Copy link
Contributor Author

tested: Swift 4.2 on both mac/linux

conqueror
conqueror approved these changes Jun 26, 2018
View reviewed changes
Copy link
Member

@conqueror conqueror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@conqueror conqueror merged commit be5ad27 into PerfectAccelerators:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conqueror conqueror conqueror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RockfordWei @conqueror