Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved usability of the tree #41

Merged
merged 77 commits into from
Feb 14, 2024
Merged

Improved usability of the tree #41

merged 77 commits into from
Feb 14, 2024

Conversation

ChristophPopp
Copy link
Contributor

Main changes:

  • implemented tags to easily find nodes via search mask
  • tree can now be collapsed or expanded interactively

Ehab Wahba and others added 30 commits October 27, 2023 17:13
Added expand and collapse buttons for node children
c42359b
Fixed zoom position on tree update
6ea3c97
Made info panel fixed
37d5d87
Updated nodes expand/collapse state after updating the tree and drawn…
607ec4c 
… expand/collapse button to nodes have children only
Added documentation
7f53545
Fixed linking new children and already shown grand children
f68fb96
Added +/- icon for expand/collapse button
166f71b
show parents of the node selected by search
2231682
show children of the node selected by search
86f3d67
Fixed functions names convention
54ed4a9
Added a resize bar for info box
6fb036b
Added resize bar dynamically for the other trees
4501275
Fixed text selection on resizing
ed3f32e
Added resize upper limit
cd0b4e5
Added search by nodes tags
0d683c1
Refactoring
35021fd
Added other trees links to the bottom of the side bar
2ac6a07
Added expand node parents
ea749c5
Update node state of expanded parents
853a721
Added documentation
55c0792
@ChristophPopp
Merge pull request #10 from PerCollECT/3-show-only-two-top-layers-by-…
89571f1 
…default

3 show only two top layers by default
Merge branch 'develop' into 6-show-child-and-parent-nodes-of-the-node…
65128fd 
…-selected-via-search-function
Fixed wrong linked parents
e88157a
Modified legend place to be on the top right
d0212af
@ChristophPopp
Merge pull request #12 from PerCollECT/6-show-child-and-parent-nodes-…
245ca04 
…of-the-node-selected-via-search-function

Resolve "show child and parent nodes of the node selected via search function"
Merge branch 'develop' into 7-split-window-in-two-fixed-areas
a7c8580
Merge branch 'develop' into 7-split-window-in-two-fixed-areas
77e3a1e
@ChristophPopp
Merge pull request #17 from PerCollECT/7-split-window-in-two-fixed-areas
67a93d2 
Resolve "split window in two fixed areas"
Modified the top layer nodes to be always on top
bb66d7f
Merge branch 'develop' into 5-add-tags-for-nodes
df63e51
Ehab Wahba and others added 19 commits January 4, 2024 12:55
Added search tags to nodes info
7839852
Removed unnecessary comments
9cc6d97
@ChristophPopp
Merge pull request #33 from PerCollECT/28-expandcollapse-the-whole-tree
4be8ec2 
28 expandcollapse the whole tree
Added legends for nodes buttons
a045cf2
Merge branch 'develop' into 32-viewbox-to-trace-the-animated-node
66876dc
@ChristophPopp
Merge pull request #34 from PerCollECT/32-viewbox-to-trace-the-animat…
2865ca8 
…ed-node

32 viewbox to trace the animated node
Merge branch 'develop' into 30-add-tags-to-node-info
dc3a23a
@ChristophPopp
Merge pull request #35 from PerCollECT/30-add-tags-to-node-info
b87c0c0 
30 add tags to node info
Merge branch 'develop' into 29-add-buttons-legends
ffcb0e1
Fixed show node by search bar
4896a3d
Added break line to legends
dfb9763
@ChristophPopp
Merge pull request #37 from PerCollECT/29-add-buttons-legends
5bbda03 
29 add buttons legends
Merge branch 'develop' into 36-clicking-on-search-result-does-not-ope…
a773906 
…n-the-node
Move the viewbox to the node found by the search bar
2429d80
Move view box on searching on existing node
2db6716
@ChristophPopp
Merge pull request #38 from PerCollECT/36-clicking-on-search-result-d…
278de3a 
…oes-not-open-the-node

36 clicking on search result does not open the node
Added borders to legends
6641b78
@ChristophPopp
Minor adaption of legend
2dd02b8
@ChristophPopp
Merge pull request #40 from PerCollECT/39-add-borders-to-legends-box
7447bfd 
Added borders to legends
@ChristophPopp ChristophPopp self-assigned this Feb 12, 2024
@ChristophPopp ChristophPopp added the enhancement New feature or request label Feb 12, 2024
ClemensLinnhoff
ClemensLinnhoff requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Just some code cleanup is necessary.

content.js Outdated Show resolved Hide resolved
@ClemensLinnhoff ClemensLinnhoff mentioned this pull request Feb 13, 2024
Merged
ClemensLinnhoff
ClemensLinnhoff reviewed Feb 14, 2024
View reviewed changes
helper.js Outdated Show resolved Hide resolved
@ClemensLinnhoff ClemensLinnhoff merged commit 0dc3961 into main Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemensLinnhoff ClemensLinnhoff ClemensLinnhoff approved these changes

@PhRosenberger PhRosenberger Awaiting requested review from PhRosenberger

Assignees

@ChristophPopp ChristophPopp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophPopp @ClemensLinnhoff