Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed get freq using LTE TDD bands in earfcn2freq function #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GermanAizek
Copy link

@FlUxIuS, here are the based fixes for correct calculation with TDD bands

@GermanAizek
Copy link
Author

@FlUxIuS, You don't want to take it out eu_arfcn_calc.py in a separate repository to pull up in other repositories as a submodule.
As result, there will be no need to add PR to modmobjam.

@GermanAizek GermanAizek changed the title Fixed get freq using LTE TDD bands in earfcn2freq and uarfcn2freq functions Fixed get freq using LTE TDD bands in earfcn2freq function Mar 23, 2023
@FlUxIuS
Copy link

FlUxIuS commented Mar 24, 2023

Thanks! I'll take a look at it this weekend :)

@FlUxIuS
Copy link

FlUxIuS commented Mar 24, 2023

@FlUxIuS, You don't want to take it out eu_arfcn_calc.py in a separate repository to pull up in other repositories as a submodule. As result, there will be no need to add PR to modmobjam.

This is maybe a good idea. I'll look for making a separate toolbox for mobile stuff.

@GermanAizek
Copy link
Author

@FlUxIuS, tell me where findband() function is defined, is it included in a third-party package?
Example here:
https://github.com/PentHertz/Modmobjam/blob/996c67c027a27573e9298b491854cdfbed5d7bd3/smartjam_rpcclient.py#L86-L96

@FlUxIuS
Copy link

FlUxIuS commented Mar 29, 2023

@FlUxIuS, tell me where findband() function is defined, is it included in a third-party package? Example here: https://github.com/PentHertz/Modmobjam/blob/996c67c027a27573e9298b491854cdfbed5d7bd3/smartjam_rpcclient.py#L86-L96

It's exactly in: utils.eu_arfcn_calc

@GermanAizek
Copy link
Author

It's exactly in: utils.eu_arfcn_calc

@FlUxIuS, Yes, that's right, I was looking in the wrong place.
https://github.com/PentHertz/Modmobmap/blob/master/utils/eu_arfcn_calc.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants