Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo on QSVT for matrix inversion #836

Merged
merged 42 commits into from
Aug 17, 2023
Merged

Demo on QSVT for matrix inversion #836

merged 42 commits into from
Aug 17, 2023

Conversation

Jaybsoni
Copy link
Contributor

Title: How To: Use QSVT for Matrix Inversion

Summary:
A demo on how to use qsvt for matrix inversion.

@Jaybsoni Jaybsoni requested a review from soranjh June 22, 2023 20:39
@soranjh soranjh changed the base branch from master to dev June 22, 2023 20:41
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 836
  • Deployment SHA: eeed9af1b2556cce36d5a1e7a671f668c6fef6d8
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

KetpuntoG
KetpuntoG reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great job! Glad to see that it is so easy to apply qsvt to new applications 😍
Here are a few comments

demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
soranjh
soranjh reviewed Jul 11, 2023
View reviewed changes
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt_real.py Outdated Show resolved Hide resolved
ixfoduap
ixfoduap requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo is looking good overall but it is currently too long and needs polishing

demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
ixfoduap
ixfoduap requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo is looking good overall but it is currently too long and needs polishing

ixfoduap
ixfoduap requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but important changes

demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
@Jaybsoni
Copy link
Contributor Author

[sc-43370]

KetpuntoG
KetpuntoG reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort here! 🚀
Two last comments, otherwise good to go

demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Show resolved Hide resolved
ixfoduap
ixfoduap approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please address these last few suggestions before merging

demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
demonstrations/tutorial_apply_qsvt.py Outdated Show resolved Hide resolved
KetpuntoG
KetpuntoG approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@KetpuntoG KetpuntoG merged commit 3f4e81c into dev Aug 17, 2023
8 checks passed
@KetpuntoG KetpuntoG deleted the qsvt_2 branch August 17, 2023 22:18
@KetpuntoG KetpuntoG restored the qsvt_2 branch August 17, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmallz333 jsmallz333 jsmallz333 left review comments

@trbromley trbromley trbromley left review comments

@mlxd mlxd mlxd left review comments

@KetpuntoG KetpuntoG KetpuntoG approved these changes

@ixfoduap ixfoduap ixfoduap approved these changes

@soranjh soranjh Awaiting requested review from soranjh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jaybsoni @mlxd @soranjh @ixfoduap @trbromley @KetpuntoG @jsmallz333