-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toric code and classical kernels demos #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmysilv
approved these changes
Apr 17, 2023
albi3ro
added a commit
that referenced
this pull request
Apr 24, 2023
* fix toric code and classical kernels demos (#740) * FIx photonics and noisy demos (#742) * FIx two demos * small change * wrap relevant results in np.array (#743) * Updated demos to work with return types (#744) * Update demos for new return types (#754) * remove pennylane-sf from dependencies * try to use developement lightning * force upgrade of lightnign * make tutorial_gbs non-executable --------- Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: lillian542 <[email protected]>
albi3ro
added a commit
that referenced
this pull request
May 2, 2023
* Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Merge dev in master following v0.28.0 release of PennyLane (#671) (#672) * Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Apply suggestions from code review Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> * Update chemical reactions demo to use pyscf for openshell H3 (#704) * use pyscf for openshell H3 * change date and fix interface warning * Change ibm device in Quantum volume (#703) * Ibm oslo * Update to new hardware * Change to Lima * Typo * Replace * One below * Update demos to remove warnings (#705) * Added interface, removed deprecated functionality * Addressing PR comments --------- Co-authored-by: Romain Moyard <[email protected]> * Update classical shadows (#708) * More * typo * Trigger CI * lightning req no depth * Trigger CI * Update SPSA demo to count circuit executions manually. (#706) * new version of SPSA demo * Update demonstrations/spsa.py Co-authored-by: Josh Izaac <[email protected]> * simplify code, update outputs and figures * Apply suggestions from code review Co-authored-by: Romain Moyard <[email protected]> * review and tweaking * make spsa an executing tutorial * move file * fix links * fix some more links * author bio * line breaks, undo link change, fixing them actually * links... * links again... bio * update to count executions manually * reword device executions -> circuit executions. avoid recreating device and qnode * print executions --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Romain Moyard <[email protected]> * Updated adaptive circuits demo for new return type (#735) * Update automatically run demos to be able to execute with v0.30 (#741) * fix toric code and classical kernels demos (#740) * FIx photonics and noisy demos (#742) * FIx two demos * small change * wrap relevant results in np.array (#743) * Updated demos to work with return types (#744) * Update demos for new return types (#754) * remove pennylane-sf from dependencies * try to use developement lightning * force upgrade of lightnign * make tutorial_gbs non-executable --------- Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: lillian542 <[email protected]> * remove nlopt from list of requirements (#755) * use dev version of lightning for demo checker (#759) * Improve formatting of output in toric code demo (#762) * round outputs on toric code * Update demonstrations/tutorial_toric_code.py Co-authored-by: Mudit Pandey <[email protected]> --------- Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> * use lightning in quantumvolume; fix qnspsa for new return; use H.sparse_matrix (#757) * use lightning in quantumvolume; fix qnspsa for new return * stop using sparse_hamiltonian * Update manually run demos (#766) * Added changes to manual demos * Updated output as found in rerun * Trigger CI * Add warnings to pennylane-sf plugins and expected output (#761) * add warnings to pennylane-sf plugins, add output * Apply suggestions from code review Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * add warning to quantum neural net --------- Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * revert workflow changes * add small gbs fixes * trigger ci * image link wrong * trigger ci --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: soranjh <[email protected]> Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: David Wierichs <[email protected]> Co-authored-by: trbromley <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: lillian542 <[email protected]> Co-authored-by: Tom Bromley <[email protected]>
BM7878
added a commit
that referenced
this pull request
May 10, 2023
* Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Merge dev in master following v0.28.0 release of PennyLane (#671) (#672) * Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Apply suggestions from code review Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> * Update chemical reactions demo to use pyscf for openshell H3 (#704) * use pyscf for openshell H3 * change date and fix interface warning * Change ibm device in Quantum volume (#703) * Ibm oslo * Update to new hardware * Change to Lima * Typo * Replace * One below * Update demos to remove warnings (#705) * Added interface, removed deprecated functionality * Addressing PR comments --------- Co-authored-by: Romain Moyard <[email protected]> * Update classical shadows (#708) * More * typo * Trigger CI * lightning req no depth * Trigger CI * Update SPSA demo to count circuit executions manually. (#706) * new version of SPSA demo * Update demonstrations/spsa.py Co-authored-by: Josh Izaac <[email protected]> * simplify code, update outputs and figures * Apply suggestions from code review Co-authored-by: Romain Moyard <[email protected]> * review and tweaking * make spsa an executing tutorial * move file * fix links * fix some more links * author bio * line breaks, undo link change, fixing them actually * links... * links again... bio * update to count executions manually * reword device executions -> circuit executions. avoid recreating device and qnode * print executions --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Romain Moyard <[email protected]> * Updated adaptive circuits demo for new return type (#735) * Update automatically run demos to be able to execute with v0.30 (#741) * fix toric code and classical kernels demos (#740) * FIx photonics and noisy demos (#742) * FIx two demos * small change * wrap relevant results in np.array (#743) * Updated demos to work with return types (#744) * Update demos for new return types (#754) * remove pennylane-sf from dependencies * try to use developement lightning * force upgrade of lightnign * make tutorial_gbs non-executable --------- Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: lillian542 <[email protected]> * remove nlopt from list of requirements (#755) * use dev version of lightning for demo checker (#759) * Improve formatting of output in toric code demo (#762) * round outputs on toric code * Update demonstrations/tutorial_toric_code.py Co-authored-by: Mudit Pandey <[email protected]> --------- Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> * use lightning in quantumvolume; fix qnspsa for new return; use H.sparse_matrix (#757) * use lightning in quantumvolume; fix qnspsa for new return * stop using sparse_hamiltonian * Update manually run demos (#766) * Added changes to manual demos * Updated output as found in rerun * Trigger CI * Add warnings to pennylane-sf plugins and expected output (#761) * add warnings to pennylane-sf plugins, add output * Apply suggestions from code review Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * add warning to quantum neural net --------- Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * Updates to utility code * Added metadata for adjoint_diff_benchmarking.py * Added metadata for tutorial_multiclass_classification.py * Added metadata for tutorial_pulse_programming101 * Added metadata for tutorial_qnn_module_torch.py * Added metadata for tutorial_spsa.py * Moved categories file * Added metadata for tutorial_here_comes_the_sun.py * [skip ci] [skip ci] * Added illustrations to metadata and updated URLs to be relative (#789) * updated metadata files * hero image added for some demos * image name updated * updated hero image * updated markdown file * folder rename --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: soranjh <[email protected]> Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: David Wierichs <[email protected]> Co-authored-by: trbromley <[email protected]> Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: lillian542 <[email protected]> Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: KetpuntoG <[email protected]> Co-authored-by: ashishks0522 <[email protected]> Co-authored-by: Ashish Kanwar Singh <[email protected]>
josh146
added a commit
that referenced
this pull request
Jun 27, 2023
* Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Merge dev in master following v0.28.0 release of PennyLane (#671) (#672) * Development branch * Bumped requirement package versions (#667) * Bumped jax versions * Updated neural-tangents * Apply suggestions from code review Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: GitHub Nightly Merge Action <[email protected]> * Update chemical reactions demo to use pyscf for openshell H3 (#704) * use pyscf for openshell H3 * change date and fix interface warning * Change ibm device in Quantum volume (#703) * Ibm oslo * Update to new hardware * Change to Lima * Typo * Replace * One below * Update demos to remove warnings (#705) * Added interface, removed deprecated functionality * Addressing PR comments --------- Co-authored-by: Romain Moyard <[email protected]> * Update classical shadows (#708) * More * typo * Trigger CI * lightning req no depth * Trigger CI * Update SPSA demo to count circuit executions manually. (#706) * new version of SPSA demo * Update demonstrations/spsa.py Co-authored-by: Josh Izaac <[email protected]> * simplify code, update outputs and figures * Apply suggestions from code review Co-authored-by: Romain Moyard <[email protected]> * review and tweaking * make spsa an executing tutorial * move file * fix links * fix some more links * author bio * line breaks, undo link change, fixing them actually * links... * links again... bio * update to count executions manually * reword device executions -> circuit executions. avoid recreating device and qnode * print executions --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Romain Moyard <[email protected]> * Updated adaptive circuits demo for new return type (#735) * Update automatically run demos to be able to execute with v0.30 (#741) * fix toric code and classical kernels demos (#740) * FIx photonics and noisy demos (#742) * FIx two demos * small change * wrap relevant results in np.array (#743) * Updated demos to work with return types (#744) * Update demos for new return types (#754) * remove pennylane-sf from dependencies * try to use developement lightning * force upgrade of lightnign * make tutorial_gbs non-executable --------- Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: lillian542 <[email protected]> * remove nlopt from list of requirements (#755) * use dev version of lightning for demo checker (#759) * Improve formatting of output in toric code demo (#762) * round outputs on toric code * Update demonstrations/tutorial_toric_code.py Co-authored-by: Mudit Pandey <[email protected]> --------- Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> * use lightning in quantumvolume; fix qnspsa for new return; use H.sparse_matrix (#757) * use lightning in quantumvolume; fix qnspsa for new return * stop using sparse_hamiltonian * Update manually run demos (#766) * Added changes to manual demos * Updated output as found in rerun * Trigger CI * Add warnings to pennylane-sf plugins and expected output (#761) * add warnings to pennylane-sf plugins, add output * Apply suggestions from code review Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * add warning to quantum neural net --------- Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Josh Izaac <[email protected]> * dev (#824) * Update requirements.txt (#825) * Update resource estimation demo for non-cubic systems (#823) * Change private methods in adjoint diff tutorial (#832) * adjoint diff tutorial improvement * Apply suggestions from code review Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> * update date --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> * Add fermionic operators demo (#813) * Fixes for 0.31 release (#835) * Updated ensemble demo * Trigger ci * Update circuit cutting demo * Updated stop_recording * Update tutorial to not rely on tape context * Update demonstrations/tutorial_quantum_circuit_cutting.py Co-authored-by: Matthew Silverman <[email protected]> --------- Co-authored-by: Matthew Silverman <[email protected]> * Modify image in fermionic demo (#838) * use new image * Added hero_illustrationd folder to _static, added fermionic_ops_hero.png, modified tutorial_fermionic_operators.py and metadata to add hero image and delete previous image. --------- Co-authored-by: CatalinaAlbornoz <[email protected]> * use pinned versions of pennylane and plugins (#840) --------- Co-authored-by: GitHub Nightly Merge Action <[email protected]> Co-authored-by: Rashid N H M <[email protected]> Co-authored-by: Jay Soni <[email protected]> Co-authored-by: soranjh <[email protected]> Co-authored-by: Romain Moyard <[email protected]> Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: David Wierichs <[email protected]> Co-authored-by: trbromley <[email protected]> Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: lillian542 <[email protected]> Co-authored-by: Tom Bromley <[email protected]> Co-authored-by: Guillermo Alonso-Linaje <[email protected]> Co-authored-by: CatalinaAlbornoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A line of the toric code needed to iterate over values in a list instead of broadcasting the operations over a numpy array.
The classical kernels demo had a variable with a single-parameter broadcasting dimension. We needed to squeeze that out so that the result didn't end up with an additional, unneeded dimension.
We should consider switching to using
qml.prod
in the toric code demo, but we can't simultaneously measure more than oneProd
at a time right now.[sc-37264]