Update deprecated usage of tape and qtape properties in QNode
#1266
+16
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
andrijapau
changed the title
tape and qtape in QNodetape and qtape properties in QNode
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
josh146
reviewed
Nov 14, 2024
| cost.construct([params - self.finite_diff_step * direction], {}) | ||
| tape_backward = cost.tape.copy(copy_operations=True) | ||
| tape_forward = qml.workflow.construct_tape(cost)(*[params + self.finite_diff_step * direction]) | ||
| tape_backward = qml.workflow.construct_tape(cost)(*[params - self.finite_diff_step * direction]) |
There was a problem hiding this comment.
Hey @andrijapau, quick question; could this part of the tutorial be rewritten as a transform?
There was a problem hiding this comment.
Imo it'll make the implementation longer and consequently, the demo less readable.
There was a problem hiding this comment.
I would say out of scope for a quick deprecation change.
mudit2812
requested changes
Nov 14, 2024
| cost.construct([params - self.finite_diff_step * direction], {}) | ||
| tape_backward = cost.tape.copy(copy_operations=True) | ||
| tape_forward = qml.workflow.construct_tape(cost)(*[params + self.finite_diff_step * direction]) | ||
| tape_backward = qml.workflow.construct_tape(cost)(*[params - self.finite_diff_step * direction]) |
There was a problem hiding this comment.
Imo it'll make the implementation longer and consequently, the demo less readable.
mudit2812
approved these changes
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
albi3ro
reviewed
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updating deprecated code that was introduced from a recent deprecation PennyLaneAI/pennylane#6583.
[sc-76836]