-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive slug field for demos in metadata.json
#1228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandrenkov
added
the
ci:build-all-qml-demos
Build all the Demos for this Pull Request
label
Oct 3, 2024
Mandrenkov
removed
the
ci:build-all-qml-demos
Build all the Demos for this Pull Request
label
Oct 3, 2024
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
anthayes92
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, appreciate the test! 🧪
doctorperceptron
approved these changes
Oct 4, 2024
1 task
Mandrenkov
added a commit
that referenced
this pull request
Oct 8, 2024
**Title:** Remove the `canonicalURL` field from demo metadata. **Summary:** This PR removes the `canonicalURL` field from existing demo metadata. The `canonicalURL` field has been superseded by the (autogenerated) `slug` field as of #1228. **Relevant references:** None. **Possible Drawbacks:** None. **Related GitHub Issues:** None. --- **Detailed Changes:** 1. Fixed the `$id` reference in `demo.metadata.schema.0.1.3.json`. 2. Added `demo.metadata.schema.0.1.4.json` which removes the `canonicalURL` field. 3. Updated the example metadata in `demonstrations_metadata.md`. 4. Removed the `canonicalURL` field from existing demo metadata (and adjusted `dateOfLastModification`). 5. Deleted the obsolete `update_metadata.py` script. **Merge Checklist:** * [x] Delete the "Build Website - Text (Test)" GHA workflow which was added for testing purposes. **Verification:** The generated `metadata.json` file in the Glass Onion bucket no longer has any `canonicalURL` fields: <details><summary><tt>metadata.json</tt> Snippet</summary> <p> ```json [ { "authors": [ { "username": "whatsis" } ], "basedOnPapers": [], "categories": [ "Quantum Computing", "How-to" ], "dateOfLastModification": "2024-10-07T00:00:00+00:00", "dateOfPublication": "2024-10-01T00:00:00+00:00", "doi": "", "previewImages": [ { "type": "thumbnail", "uri": "/_static/demo_thumbnails/regular_demo_thumbnails/thumbnail_how_to_use_noise_models.png" }, { "type": "large_thumbnail", "uri": "/_static/demo_thumbnails/large_demo_thumbnails/thumbnail_large_how_to_use_noise_models.png" } ], "referencedByPapers": [], "references": [], "relatedContent": [ { "id": "tutorial_noisy_circuits", "type": "demonstration", "weight": 1 } ], "seoDescription": "Learn how noise models can be built and inserted into a quantum circuit in PennyLane.", "slug": "tutorial_how_to_use_noise_models", "tags": [], "title": "How to use noise models in PennyLane" }, ... ] ``` </p> </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a
slug
field to each item inmetadata.json
. The slug is derived from the filename of the demo and will eventually replace thecanonicalURL
field. In a subsequent PR, the canonical URL field will be removed.Relevant references:
None.
Possible Drawbacks:
None.
Related GitHub Issues:
None.
Other Notes:
Verification:
The generated
metadata.json
file has the correctslug
field for each demo in the Glass Onion bucket.metadata.json Snippet