-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc-70154-update-qml-readme-to-highlight-image-standards #1184
Merged
ashishks0522
merged 3 commits into
master
from
sc-70154-update-qml-readme-to-highlight-image-standards
Aug 29, 2024
Merged
sc-70154-update-qml-readme-to-highlight-image-standards #1184
ashishks0522
merged 3 commits into
master
from
sc-70154-update-qml-readme-to-highlight-image-standards
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishks0522
requested review from
tarik-elkhateeb,
AndrewGardhouse and
Alan-eMartin
August 8, 2024 18:29
tarik-elkhateeb
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, thanks @ashishks0522
Alan-eMartin
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside whatever is failing this looks good to me
Thank you ashish! |
ashishks0522
deleted the
sc-70154-update-qml-readme-to-highlight-image-standards
branch
August 29, 2024 20:53
mudit2812
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Ticket - [sc-70154-update-qml-readme-to-highlight-image-standards](https://app.shortcut.com/xanaduai/story/70154/update-qml-readme-to-highlight-image-standards) ## Changes - Add instructions to `README.md` about image standards to be followed while writing demos this QML repository. - Requirements sources from this [doc](https://www.notion.so/xanaduai/Image-standards-for-web-projects-264c09e45a8941a597918b878a2f1a5e) - Since QML is public & the notion doc is private (accessible by Xanadu only) added the relevant standards in text form in the `README.md` ## Preview - https://github.com/PennyLaneAI/qml/blob/2e9da1bb2bef3cd8a2eb504459f686ab20b9ec0c/README.md
cosenal
pushed a commit
to unitaryfund/qml
that referenced
this pull request
Sep 7, 2024
…1184) ## Ticket - [sc-70154-update-qml-readme-to-highlight-image-standards](https://app.shortcut.com/xanaduai/story/70154/update-qml-readme-to-highlight-image-standards) ## Changes - Add instructions to `README.md` about image standards to be followed while writing demos this QML repository. - Requirements sources from this [doc](https://www.notion.so/xanaduai/Image-standards-for-web-projects-264c09e45a8941a597918b878a2f1a5e) - Since QML is public & the notion doc is private (accessible by Xanadu only) added the relevant standards in text form in the `README.md` ## Preview - https://github.com/PennyLaneAI/qml/blob/2e9da1bb2bef3cd8a2eb504459f686ab20b9ec0c/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Changes
README.md
about image standards to be followed while writing demos this QML repository.README.md
Preview