Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-70154-update-qml-readme-to-highlight-image-standards #1184

Merged

Conversation

ashishks0522
Copy link
Collaborator

@ashishks0522 ashishks0522 commented Aug 8, 2024

Ticket

Changes

  • Add instructions to README.md about image standards to be followed while writing demos this QML repository.
  • Requirements sources from this doc
  • Since QML is public & the notion doc is private (accessible by Xanadu only) added the relevant standards in text form in the README.md

Preview

@ashishks0522 ashishks0522 marked this pull request as ready for review August 8, 2024 18:29
Copy link

@tarik-elkhateeb tarik-elkhateeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks @ashishks0522

Copy link

@Alan-eMartin Alan-eMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside whatever is failing this looks good to me

@Alan-eMartin
Copy link

Thank you ashish!

@ashishks0522 ashishks0522 merged commit 52acfc0 into master Aug 29, 2024
6 checks passed
@ashishks0522 ashishks0522 deleted the sc-70154-update-qml-readme-to-highlight-image-standards branch August 29, 2024 20:53
mudit2812 pushed a commit that referenced this pull request Sep 4, 2024
## Ticket
-
[sc-70154-update-qml-readme-to-highlight-image-standards](https://app.shortcut.com/xanaduai/story/70154/update-qml-readme-to-highlight-image-standards)

## Changes
- Add instructions to `README.md` about image standards to be followed
while writing demos this QML repository.
- Requirements sources from this
[doc](https://www.notion.so/xanaduai/Image-standards-for-web-projects-264c09e45a8941a597918b878a2f1a5e)
- Since QML is public & the notion doc is private (accessible by Xanadu
only) added the relevant standards in text form in the `README.md`

## Preview
-
https://github.com/PennyLaneAI/qml/blob/2e9da1bb2bef3cd8a2eb504459f686ab20b9ec0c/README.md
cosenal pushed a commit to unitaryfund/qml that referenced this pull request Sep 7, 2024
…1184)

## Ticket
-
[sc-70154-update-qml-readme-to-highlight-image-standards](https://app.shortcut.com/xanaduai/story/70154/update-qml-readme-to-highlight-image-standards)

## Changes
- Add instructions to `README.md` about image standards to be followed
while writing demos this QML repository.
- Requirements sources from this
[doc](https://www.notion.so/xanaduai/Image-standards-for-web-projects-264c09e45a8941a597918b878a2f1a5e)
- Since QML is public & the notion doc is private (accessible by Xanadu
only) added the relevant standards in text form in the `README.md`

## Preview
-
https://github.com/PennyLaneAI/qml/blob/2e9da1bb2bef3cd8a2eb504459f686ab20b9ec0c/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants