Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-69242-create-how-to-category-in-qml-repository #1163

Merged
merged 5 commits into from
Jul 23, 2024
Merged

sc-69242-create-how-to-category-in-qml-repository #1163

merged 5 commits into from
Jul 23, 2024

Conversation

ashishks0522
Copy link
Collaborator

Changes

  • Add How-To category in JSON schema

@ashishks0522
Copy link
Collaborator Author

@ikurecic if you could help review and confirm how we want the How-To category copy to be?

doctorperceptron
doctorperceptron approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@doctorperceptron doctorperceptron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @ikurecic sign-off on the formatting for "How-To".

ikurecic
ikurecic reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tag.
What would be a good time to start adding this category to existing PennyLane Demos?

README.md Outdated Show resolved Hide resolved
metadata_schemas/demo.metadata.schema.0.1.1.json Outdated Show resolved Hide resolved
ashishks0522 and others added 2 commits July 22, 2024 10:53
@ashishks0522
Copy link
Collaborator Author

Thank you for the tag. What would be a good time to start adding this category to existing PennyLane Demos?

As soon as this PR is merged in, we should be good to start using this category

@ikurecic
Copy link
Contributor

Thank you for the tag. What would be a good time to start adding this category to existing PennyLane Demos?

As soon as this PR is merged in, we should be good to start using this category

Thanks. As discussed at the pennylane.ai meeting today, I can have a pull request ready to assign this category to existing PennyLane Demos by 25 July.
Would it be best if I committed as part of this pull request, @ashishks0522 ?

@ashishks0522
Copy link
Collaborator Author

ashishks0522 commented Jul 22, 2024 •
edited
Loading

Thanks. As discussed at the pennylane.ai meeting today, I can have a pull request ready to assign this category to existing PennyLane Demos by 25 July. Would it be best if I committed as part of this pull request, @ashishks0522 ?

I think we can just merge this one in to have the schema changes in master then you can create a pull request from master and continue with the work, since github checks might run based on what's in the master branch, this way they won't fail for this new category

ikurecic
ikurecic approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, @ashishks0522 , if that sounds good to you, let's do that. Thanks.

@ashishks0522 ashishks0522 merged commit d47b6f9 into master Jul 23, 2024
6 checks passed
@ashishks0522 ashishks0522 deleted the sc-69242-create-how-to-category-in-qml-repository branch July 23, 2024 13:13
@ikurecic ikurecic mentioned this pull request Jul 24, 2024
Merged
ikurecic added a commit that referenced this pull request Jul 24, 2024
@ikurecic
Add How-to category to select PennyLane Demos (#1168)
4b13386 
As described in associated story.

Related to #1163 

Please note I added a metadata description — do add suggestions if a
change is necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctorperceptron doctorperceptron doctorperceptron approved these changes

@ikurecic ikurecic ikurecic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashishks0522 @ikurecic @doctorperceptron