Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lie-sim demo #1085

Merged
merged 359 commits into from
Jun 7, 2024
Merged

Lie-sim demo #1085

merged 359 commits into from
Jun 7, 2024

Conversation

Qottmann
Copy link
Collaborator

@Qottmann Qottmann commented Apr 29, 2024

A demo and discussion of Lie algebraic simulation techniques, i.e. papers https://arxiv.org/abs/1012.2873 and https://arxiv.org/abs/2308.01432

If you are writing a demonstration, please answer these questions to facilitate the marketing process.

If you are writing a demonstration, please answer these questions to facilitate the marketing process.

  • GOALS — Why are we working on this now?
    g-sim is a hot topic. Most prominently, it shows that systems with provably absent barren plateaus can be simulated efficiently. This is conceptually interesting, though likely not very relevant in practice since the systems for which this is indeed the case are very rare.

  • AUDIENCE — Who is this for?
    Quantum researchers, practitioners with a fair understanding. In combination with the linked Intro to DLA demo this should also be suitable for beginners.

  • KEYWORDS — What words should be included in the marketing post?

    • dynamical Lie algebra / Lie groups
    • g-sim
    • barren plateaus
  • Which of the following types of documentation is most similar to your file?
    (more details here)

  • Tutorial
  • Demo
  • How-to

[sc-58429]

actions-user and others added 30 commits June 5, 2023 21:07
* adjoint diff tutorial improvement

* Apply suggestions from code review

Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Matthew Silverman <[email protected]>

* update date

---------

Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Matthew Silverman <[email protected]>
* Updated ensemble demo

* Trigger ci

* Update circuit cutting demo

* Updated stop_recording

* Update tutorial to not rely on tape context

* Update demonstrations/tutorial_quantum_circuit_cutting.py

Co-authored-by: Matthew Silverman <[email protected]>

---------

Co-authored-by: Matthew Silverman <[email protected]>
* use new image

* Added hero_illustrationd folder to _static, added fermionic_ops_hero.png, modified tutorial_fermionic_operators.py and metadata to add hero image and delete previous image.

---------

Co-authored-by: CatalinaAlbornoz <[email protected]>
* Test interactive demo

* Test interactive demo

* fix

* Test interactive demo

* fix

* fix

* fix

* fix

* absolute directories
* Interactive demo

* Interactive test3

* fix
Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Qottmann , here are just a few comments.

Also a note that there's a rendering issue with headings (the ToC in the right-side panel doesn't respond well to the used inline math) that I'm following up about.

demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
Comment on lines 8 to 9
Let us see what the fuss is all about and learn about the conceptually interesting, yet practically not-too-relevant
Lie-algebraic simulation techniques of variational quantum circuits in :math:`\mathfrak{g}`-sim.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you are not selling it at all. 😅 Instead of this, can you drop a linebreak and write a sentence that convinces me I should be interested?
Also, g-sim comes up with zero context. Maybe prefacing with a sentence of explanation would be helpful?

Maybe you could even explicitly mention your previous demo and say how this builds onto it?

As a reader, I would also want to know what you will be showing in the demo. I made a comment in the concluding paragraph about this — maybe you can use this space to explicitly say what you're coding here and what for?

Copy link
Collaborator Author

@Qottmann Qottmann Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not trying to sell it, but rather give a disclaimer: this is for the most part useless in practice. It is conceptually interesting, and in the context provided above and below certainly relevant. But the reality is that only very few systems lead to polynomially sized DLAs where this is practically relevant (essentially boiling down to the TFIM)

I made some changes to address your other comments ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, maybe you should say that outright, then?
Just because, if I read this opening paragraph without any other context, I would not have any interest in continuing. 🤔
Does that make sense? You don't have to endorse or recommend anything, but you spent a lot of time writing this, and there's got to be a reason for that. :) We do want people to read and learn from your work, so we should tell them why. Explicitly adding this 'disclaimer' in the opener might be a very good way of doing that. Would something like that vibe with you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha okay I am all for being in-the-face, let me know if you find the new version more engaging. There is also an intermediary version that I can be found in the commit before the latest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
The in-between version (this one, right?) is great.
If you want to revert to that, shall we call it done?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I also like that one better. Pushing the revert now

demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Show resolved Hide resolved
Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch, @Qottmann , I've replied in the threads.
I can also add that the inline-math-in-headings rendering issue has been solved now.

Comment on lines 8 to 9
Let us see what the fuss is all about and learn about the conceptually interesting, yet practically not-too-relevant
Lie-algebraic simulation techniques of variational quantum circuits in :math:`\mathfrak{g}`-sim.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, maybe you should say that outright, then?
Just because, if I read this opening paragraph without any other context, I would not have any interest in continuing. 🤔
Does that make sense? You don't have to endorse or recommend anything, but you spent a lot of time writing this, and there's got to be a reason for that. :) We do want people to read and learn from your work, so we should tell them why. Explicitly adding this 'disclaimer' in the opener might be a very good way of doing that. Would something like that vibe with you?

demonstrations/tutorial_liesim.py Outdated Show resolved Hide resolved
demonstrations/tutorial_liesim.py Show resolved Hide resolved
@Qottmann Qottmann requested a review from ikurecic June 7, 2024 11:58
Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Qottmann , looks great — looking forward to seeing the next one.

@Qottmann Qottmann merged commit 9a60300 into master Jun 7, 2024
10 checks passed
@Qottmann Qottmann deleted the liesim branch June 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.