Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fermionic to qubit mapping demo #1077

Merged
merged 23 commits into from
May 7, 2024
Merged

Add fermionic to qubit mapping demo #1077

merged 23 commits into from
May 7, 2024

Conversation

ddhawan11
Copy link
Contributor

@ddhawan11 ddhawan11 commented Apr 23, 2024

Title:
Mapping fermionic Hamiltonian to qubit Hamiltonian

Summary:

Relevant references:
Tranter, Andrew, et. al. "A comparison of the Bravyi-Kitaev and the Jordan-Wigner transformations for the quantum simulation of quantum _chemistry." Journal of chemical theory and computation 14.11 (2018): 5617-5630.

Possible Drawbacks:

Related GitHub Issues:


If you are writing a demonstration, please answer these questions to facilitate the marketing process.

  • GOALS — Why are we working on this now?
    Promote a new PL feature.

  • AUDIENCE — Who is this for?
    Chemistry researcher

  • KEYWORDS — What words should be included in the marketing post?
    Fermionic Mapping

  • Which of the following types of documentation is most similar to your file?
    (more details here)

  • Tutorial
  • Demo
  • How-to

@ddhawan11 ddhawan11 marked this pull request as draft April 23, 2024 16:00
@ddhawan11 ddhawan11 requested a review from soranjh April 23, 2024 16:01
@ddhawan11 ddhawan11 marked this pull request as ready for review April 25, 2024 14:59
@ddhawan11 ddhawan11 changed the title [WIP] add mapping tutorial [WIP] Mapping Demo Apr 26, 2024
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, left some high-level comments for now.

demonstrations/tutorial_mapping.metadata.json Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
@soranjh soranjh changed the base branch from master to dev April 29, 2024 17:17
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, left a second round of high-level comments. When they are addresses, I will put some minor modification comments on the text.

demonstrations/tutorial_mapping.metadata.json Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.metadata.json Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
@soranjh soranjh changed the base branch from dev to master April 29, 2024 17:55
@KetpuntoG
Copy link
Contributor

Hey @soranjh , Until next Monday, the master branch will continue with the previous version of pennylane. I recommend point to dev to be able to merge this week

@soranjh
Copy link
Contributor

soranjh commented Apr 29, 2024

Hey @soranjh , Until next Monday, the master branch will continue with the previous version of pennylane. I recommend point to dev to be able to merge this week

It was originally based on master, we will fix this.

Copy link

github-actions bot commented May 1, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1077
  • Deployment SHA: a7c96496fc23052c2d2593268852b2607555040d
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ddhawan11, left another set of comments.

demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
demonstrations/tutorial_mapping.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ddhawan11 🚀
A great first contribution

@soranjh soranjh merged commit 72d4bc4 into dev May 7, 2024
10 checks passed
@soranjh soranjh deleted the mapping branch May 7, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants