Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demos to use new opmath #1067

Merged
merged 27 commits into from
Apr 25, 2024
Merged

Update demos to use new opmath #1067

merged 27 commits into from
Apr 25, 2024

Conversation

Qottmann
Copy link
Collaborator

@Qottmann Qottmann commented Apr 9, 2024

Remove explicit qml.operation.Tensor instances, as well as qml.ops.Hamiltonian usage

branching against dev as new opmath will be default only in v0.36 (scheduled for 07. May)

Copy link

github-actions bot commented Apr 9, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

Copy link

github-actions bot commented Apr 9, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1067
  • Deployment SHA: f5fea63ffcd22739115c79d9a7d80437a18c4382
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

@Qottmann Qottmann added the ci:build-all-qml-demos Build all the Demos for this Pull Request label Apr 11, 2024
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers @Qottmann .

@Qottmann
Copy link
Collaborator Author

Qottmann commented Apr 11, 2024

Because deprecation warnings are treated as failures, I just pushed another change removing all occurences of explicit H.ops or H.coeffs calls and replaced them with H_coeffs, H_ops = H.terms().

edit: now with all demos running, there seems to be more work required. I will tag again for review once I fix all of them 👍

@Qottmann
Copy link
Collaborator Author

Currently blocked by PennyLaneAI/pennylane#5475 and PennyLaneAI/pennylane-qulacs#64 to be merged

Any way to skip that demo for the moment to make sure the others pass?

@Qottmann
Copy link
Collaborator Author

[sc-53506]

@Qottmann
Copy link
Collaborator Author

Qottmann commented Apr 17, 2024

Currently blocked by tutorial_qubit_tapering due to PennyLaneAI/pennylane#5532

Edit: Doing a work-around to not be blocked by this for the moment. Left a Todo in the PR description to change it back once that issue is resolved

@Qottmann
Copy link
Collaborator Author

Just noticed a bug in another demo with the latest updates to pennylane. Should be fixed now 🤞

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! To be sure, have we checked that all of these still run without error?

demonstrations/tutorial_qubit_tapering.py Show resolved Hide resolved
@Qottmann
Copy link
Collaborator Author

Looks good to me! To be sure, have we checked that all of these still run without error?

Yes, this PR is in fact building all demos due to the tag

@Qottmann Qottmann requested a review from astralcai April 24, 2024 10:36
@Qottmann Qottmann enabled auto-merge (squash) April 25, 2024 16:58
@Qottmann Qottmann merged commit 13bf15a into dev Apr 25, 2024
19 checks passed
@Qottmann Qottmann deleted the newopmath branch April 25, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build-all-qml-demos Build all the Demos for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants