-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QCBM Tutorial #1053
QCBM Tutorial #1053
Conversation
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
Hello! Good job here @Gopal-Dahale ! |
@KetpuntoG Yes it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks for working on this 😊
Here I share with you a first round of comments.
Although all the content looks good, I am convinced that we can make this demo shine much more 🚀Also I would try to make the structure follow a more continuous thread instead of marking epigraphs like "Loss" or "Gradient".
This demo is a great reference for that: https://pennylane.ai/qml/demos/tutorial_intro_qsvt/
As you can see in that demo, the code is quite simplified and makes use of comments but not excessively. I'm sure you can get some good inspiration from the style 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for all the changes, it looks great!
I will talk to our designer to create the thumbnail. Do you have any suggestions on how it should look like?
Once you work on my last comments, I will assign a colleague for the second review :)
Co-authored-by: Guillermo Alonso-Linaje <[email protected]>
Maybe a quantum circuit outputting a probability distribution. something similar to the quantum gan thumbnail. This is just a suggestion. I think PennyLane's design team is already well-versed and creative 😅. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gopal-Dahale!
I'll be doing the second review for your demo. I'll get back to you by Friday. Looking forward to reading it 🤩!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! Results are super good and plotted in an intuitive way! Not many things to fix except for some typos, a bit of grammar, and maybe some clarity here and there 🚀 Will be ready to go soon ⭐
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Co-authored-by: Alvaro Ballon <[email protected]>
Great job! Once I update the thumbnail, it's ready to publish 😄 |
Thank you @KetpuntoG. @KetpuntoG and @alvaro-at-xanadu there are a few conversations which are yet to be resolved. Can you take a look at them? I have left some comments. |
I spoke with marketing and the demo will be released in mid-May, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks great
@alvaro-at-xanadu what do you think? |
Title:
Quantum Circuit Born Machines
Summary:
Introduces the ideas of Quantum Circuit Born Machines (QCBMs) along with its gradient-based training. Applies QCBM to learn bars and stripes and two peaks dataset.
Relevant references:
Differentiable Learning of Quantum Circuit Born Machine
Possible Drawbacks:
Related GitHub Issues:
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?: The purpose is to use PennyLane to implement a popular algorithm in unsupervised generative modelling based on the paper "Differentiable Learning of Quantum Circuit Born Machine".
AUDIENCE — Who is this for?: The demo provides a gentle introduction to QCBMs, making it suitable for beginners. It also targets individuals interested in generative modelling with quantum algorithms.
KEYWORDS — What words should be included in the marketing post?: QCBM, QML, MMD, Gradient-based Optimization
Which of the following types of documentation is most similar to your file?
(more details here)