Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table reporting on Docker builds. #65

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add table reporting on Docker builds. #65

merged 4 commits into from
Jan 31, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jan 24, 2024 •
edited by Alex-Preciado
Loading

@vincentmr vincentmr requested a review from a team January 24, 2024 20:27
timmysilv
timmysilv approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment to avoid ambiguity, but otherwise looks good!

README.md Outdated Show resolved Hide resolved
@vincentmr @timmysilv
Update README.md
4ded12e 
Co-authored-by: Matthew Silverman <[email protected]>
@vincentmr
Copy link
Contributor Author

@timmysilv Thanks! I was thinking other Docker workflows could be reported in the table eventually, but let's keep Lightning in the title to avoid ambiguity for now.

@trbromley
Copy link
Contributor

How often are the actions run?

@vincentmr
Copy link
Contributor Author

How often are the actions run?

Every day of the week @4am.

@vincentmr vincentmr requested a review from timmysilv January 29, 2024 14:06
@timmysilv
Copy link
Contributor

are the jobs supposed to be running? I'm seeing "no status" on the master badge

@vincentmr
Copy link
Contributor Author

are the jobs supposed to be running? I'm seeing "no status" on the master badge

That's because there is a bit of a chicken-and-egg situation between the repos. The jobs have not run on master yet, but the labels showed correctly when master was replaced by the correct branch name. That said, it's been merged now, so I'll trigger the workflows and let's see if everything shows correctly before merging.

@vincentmr
Copy link
Contributor Author

Both labels should show green now, I think we're good to go.

@Alex-Preciado
Copy link
Contributor

Merging on behalf of @vincentmr 🙏🏼

@Alex-Preciado Alex-Preciado merged commit b80c0b3 into master Jan 31, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lillian542 lillian542 lillian542 approved these changes

@timmysilv timmysilv timmysilv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vincentmr @trbromley @timmysilv @Alex-Preciado @lillian542