Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not raise deprecation warnings as errors on braket #63

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

timmysilv
Copy link
Contributor

the errors hide meaningful results in the case of braket tests, so we should stop raising PL deprecation warnings as errors there.

I've added a mechanism to disable it for any plugin, by setting no_deprecation_error to True (or any value, really) in the plugin's definition in compile.py.

@timmysilv timmysilv requested review from lillian542 and a team January 5, 2024 17:43
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I approve

@timmysilv timmysilv merged commit 92693b3 into master Jan 9, 2024
45 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants