Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin test matrix/add gpu #54

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Plugin test matrix/add gpu #54

merged 2 commits into from
Oct 27, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 26, 2023

This PR removes L-GPU and L-Kokkos from the plugin matrix since these repos have been archived after being integrated in the Lightning monorepo. The new compatibility workflows of the monorepo now included tests of both backends on GPU runners.

@vincentmr vincentmr requested a review from a team October 26, 2023 19:30
@timmysilv
Copy link
Contributor

does this mean that if any one lightning device fails, then the badge on the matrix will turn red?

@vincentmr
Copy link
Contributor Author

does this mean that if any one lightning device fails, then the badge on the matrix will turn red?

Yes, clicking the link we'll know which one. I've check this out with @trbromley and @mlxd before.

Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's perfect, thanks!

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentmr is there any remaining work on this PR? Asking because it's still a draft PR, if not, I'll merge it immediately.

@vincentmr vincentmr marked this pull request as ready for review October 27, 2023 16:16
@vincentmr
Copy link
Contributor Author

No, forgot to change the status. I think it's good to go.

@mudit2812 mudit2812 merged commit b26723a into master Oct 27, 2023
38 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants