Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning workflows moved to monorepo. #50

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Lightning workflows moved to monorepo. #50

merged 4 commits into from
Oct 2, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Sep 14, 2023 •
edited
Loading

Context:
SC-43411 requires compatibility tests between PennyLane and Lightning's most recent stable releases and development versions.

Description of the Change:
This PR removes the Lightning workflows which are now part of Lightning itself (like L-GPU and L-Kokkos). The Lightning status links in README are updated accordingly.

Related GitHub issues
PennyLaneAI/pennylane-lightning#498

@vincentmr vincentmr requested a review from rashidnhm September 14, 2023 16:27
@vincentmr vincentmr mentioned this pull request Sep 22, 2023
Merged
5 tasks
AmintorDusko
AmintorDusko approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincent, that's a sensible change. Thank you for that.

@vincentmr vincentmr requested a review from a team September 22, 2023 21:00
@timmysilv
Copy link
Contributor

darn, my CI workflow that I added didn't account for untracked files. Anyway, could you please remove lightning from compile.py?

Also, the base lightning links still point to plugin-test-matrix CI actions that you're removing. Can you update those to their new action location?

@vincentmr
Copy link
Contributor Author

darn, my CI workflow that I added didn't account for untracked files. Anyway, could you please remove lightning from compile.py?

Also, the base lightning links still point to plugin-test-matrix CI actions that you're removing. Can you update those to their new action location?

Thanks for that. Links are fixed, I think, but some workflows in Lightning might require an update.

@vincentmr vincentmr requested a review from albi3ro October 2, 2023 13:49
albi3ro
albi3ro reviewed Oct 2, 2023
View reviewed changes
README.md Show resolved Hide resolved
@vincentmr
Copy link
Contributor Author

@albi3ro Could you please merge this? I cannot as some plugins are failing.

@timmysilv timmysilv merged commit 75a90be into master Oct 2, 2023
30 of 56 checks passed
@vincentmr vincentmr deleted the update/lightning branch October 2, 2023 18:15
@vincentmr
Copy link
Contributor Author

Thanks @AmintorDusko @albi3ro and @timmysilv

@timmysilv timmysilv mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmintorDusko AmintorDusko AmintorDusko approved these changes

@timmysilv timmysilv timmysilv approved these changes

@albi3ro albi3ro albi3ro approved these changes

@rashidnhm rashidnhm Awaiting requested review from rashidnhm

@mlxd mlxd Awaiting requested review from mlxd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincentmr @timmysilv @albi3ro @AmintorDusko