Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml.execute no longer accepts mcm_config argument #6807

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jan 10, 2025

Context:

Further qml.workflow clean-up.

Found usage in Catalyst: PennyLaneAI/catalyst#1452
No usage in Lightning.

Description of the Change:

Introduce kwargs postselect_mode and mcm_method to qml.execute signature. Raise deprecation warning to user if they try to use mcm_config kwarg.

Side-effect: Had to xfail any tests that had to do with Catalyst since they assume certain keys from the QNode.execute_kwargs.

Benefits:

Keyword parity with qml.QNode.

Possible Drawbacks: None identified.

[sc-80541]

This comment was marked as resolved.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add an entry to deprecations.rst.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (b42e89e) to head (b02f0f0).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6807      +/-   ##
==========================================
- Coverage   99.60%   99.56%   -0.05%     
==========================================
  Files         476      476              
  Lines       45237    45241       +4     
==========================================
- Hits        45060    45043      -17     
- Misses        177      198      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Yushao Chen (Jerry) <[email protected]>
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants