-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml.execute
no longer accepts mcm_config
argument
#6807
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add an entry to deprecations.rst
.
Co-authored-by: Christina Lee <[email protected]>
This reverts commit 8d61d2e.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6807 +/- ##
==========================================
- Coverage 99.60% 99.56% -0.05%
==========================================
Files 476 476
Lines 45237 45241 +4
==========================================
- Hits 45060 45043 -17
- Misses 177 198 +21 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Context:
Further
qml.workflow
clean-up.Found usage in Catalyst: PennyLaneAI/catalyst#1452
No usage in Lightning.
Description of the Change:
Introduce kwargs
postselect_mode
andmcm_method
toqml.execute
signature. Raise deprecation warning to user if they try to usemcm_config
kwarg.Side-effect: Had to
xfail
any tests that had to do with Catalyst since they assume certain keys from theQNode.execute_kwargs
.Benefits:
Keyword parity with
qml.QNode
.Possible Drawbacks: None identified.
[sc-80541]