Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.mixed to default.qubit.legacy in test_qnode_legacy.py #6634

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Nov 25, 2024

Context:

default.mixed is currently being ported over to the new device API. Therefore, test_qnode_legacy.py should be updated to remove default.mixed and replace it with DefaultQubitLegacy.

Description of the Change:

qml.device("default.mixed", ...)DefaultQubitLegacy(...)

Benefits: Code clean-up.

Possible Drawbacks: None

[sc-78490]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@andrijapau andrijapau changed the title Update default.mixed to default.qubit.legacy in `test_qnode_legacy.py Update default.mixed to default.qubit.legacy in test_qnode_legacy.py Nov 25, 2024
@andrijapau
Copy link
Contributor Author

Do I need a changelog for this? @mudit2812 / @lillian542

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (672ba48) to head (b2927c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6634   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         455      455           
  Lines       42820    42820           
=======================================
  Hits        42671    42671           
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

tests/test_qnode_legacy.py Show resolved Hide resolved
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I wouldn't think it needs a changelog entry.

@andrijapau andrijapau enabled auto-merge (squash) November 27, 2024 20:57
@andrijapau andrijapau merged commit ba7b15b into master Nov 27, 2024
46 checks passed
@andrijapau andrijapau deleted the update-test-devices branch November 27, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants