-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default.mixed
to default.qubit.legacy
in test_qnode_legacy.py
#6634
Conversation
Hello. You may have forgotten to update the changelog!
|
default.mixed
to default.qubit.legacy
in `test_qnode_legacy.pydefault.mixed
to default.qubit.legacy
in test_qnode_legacy.py
Do I need a changelog for this? @mudit2812 / @lillian542 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6634 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 455 455
Lines 42820 42820
=======================================
Hits 42671 42671
Misses 149 149 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I wouldn't think it needs a changelog entry.
Context:
default.mixed
is currently being ported over to the new device API. Therefore,test_qnode_legacy.py
should be updated to removedefault.mixed
and replace it withDefaultQubitLegacy
.Description of the Change:
qml.device("default.mixed", ...)
→DefaultQubitLegacy(...)
Benefits: Code clean-up.
Possible Drawbacks: None
[sc-78490]