-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulate of analytic case for DefaultMixedNewAPI #6618
base: add-qubit_mixed/measure
Are you sure you want to change the base?
Add simulate of analytic case for DefaultMixedNewAPI #6618
Conversation
Mimicing the qutrit mixed one.
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
The three fails up to now are all expected; will fix when the blockers were removed and this branch got updated |
Co-authored-by: lillian542 <[email protected]>
@lillian542 I just rebased to the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-qubit_mixed/measure #6618 +/- ##
===========================================================
- Coverage 99.65% 99.64% -0.01%
===========================================================
Files 456 456
Lines 43019 43084 +65
===========================================================
+ Hits 42870 42933 +63
- Misses 149 151 +2 ☔ View full report in Codecov by Sentry. |
Put DO NOT MERGE since currently we are only comparing it with another in-progress branch instead of requesting to merge. |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The implementation of method
simulate
is the most important one under the architecture of new API standard. The point ofsimulate
, is basically abstract both the analytic version (controlled byshots=None
, or infinite shots in a fancier way) and the MC version (finite shots). Meanwhile, the functionality of such method should not truly depend on our details of qml implementationi; they better only rely on either the fundamental computation libs, e.g. math lib and qnp, or the most essential infras, e.g. Tape/Scripts and Operations.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-73320]