Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always install cvxpy/cvxopt in test CI now that there are 3.11 wheels #4128

Merged
merged 2 commits into from
May 15, 2023

Conversation

timmysilv
Copy link
Contributor

This was added in #3276 to allow for 3.11 support, but now the wheels exist (cvxopt/cvxopt#228)! I'm just un-doing the changes done in that python upgrade PR.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #4128 (fae281f) into master (1a1b070) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4128   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         345      345           
  Lines       30864    30864           
=======================================
  Hits        30792    30792           
  Misses         72       72           

@timmysilv timmysilv requested a review from a team May 15, 2023 18:01
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@rmoyard rmoyard self-requested a review May 15, 2023 18:05
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timmysilv timmysilv enabled auto-merge (squash) May 15, 2023 18:55
@timmysilv timmysilv merged commit abe7be8 into master May 15, 2023
@timmysilv timmysilv deleted the add-back-cvxpy branch May 15, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants