-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noncubic lattice for all electron resource estimation #3956
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #3956 +/- ##
========================================
Coverage 99.77% 99.77%
========================================
Files 342 342
Lines 30752 30887 +135
========================================
+ Hits 30682 30817 +135
Misses 70 70
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I left a lot of comments, mostly just going through the equations.
No need to reply to all of them, they are just places where I wasn't sure the code matched the papers and brought it up in case it is worth double checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I left a lot of comments, mostly just going through the equations.
No need to reply to all of them, they are just places where I wasn't sure the code matched the papers and brought it up in case it is worth double checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo to fix, but approving so that merging is not blocked. Looks great! Good work.
Context:
Adding non-cubic lattice support for all electron resource estimation.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: