Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noncubic lattice for all electron resource estimation #3956

Merged
merged 48 commits into from
Jun 5, 2023

Conversation

mojishoki
Copy link

@mojishoki mojishoki commented Mar 31, 2023

Context:
Adding non-cubic lattice support for all electron resource estimation.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

pennylane/resource/first_quantization.py Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #3956 (61108dd) into master (6f3b080) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #3956    +/-   ##
========================================
  Coverage   99.77%   99.77%            
========================================
  Files         342      342            
  Lines       30752    30887   +135     
========================================
+ Hits        30682    30817   +135     
  Misses         70       70            
Impacted Files Coverage Δ
pennylane/resource/first_quantization.py 99.66% <100.00%> (+0.28%) ⬆️

pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
@soranjh soranjh marked this pull request as ready for review May 8, 2023 18:40
@soranjh soranjh requested a review from DSGuala May 8, 2023 18:40
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left a lot of comments, mostly just going through the equations.
No need to reply to all of them, they are just places where I wasn't sure the code matched the papers and brought it up in case it is worth double checking.

pennylane/resource/first_quantization.py Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Show resolved Hide resolved
pennylane/resource/first_quantization.py Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Show resolved Hide resolved
pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
pennylane/resource/first_quantization.py Show resolved Hide resolved
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left a lot of comments, mostly just going through the equations.
No need to reply to all of them, they are just places where I wasn't sure the code matched the papers and brought it up in case it is worth double checking.

@soranjh soranjh requested a review from DSGuala May 31, 2023 21:34
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo to fix, but approving so that merging is not blocked. Looks great! Good work.

pennylane/resource/first_quantization.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants