-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test suite speed: pytest-xdist
; qcut
and qchem
markers; update reconstruct tests
#2504
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
==========================================
+ Coverage 97.23% 99.47% +2.24%
==========================================
Files 244 244
Lines 19433 19433
==========================================
+ Hits 18895 19331 +436
+ Misses 538 102 -436
Continue to review full report at Codecov.
|
This reverts commit c1d6a22.
xdist
, qcut
and qchem
markers, update reconstruct tests
…nnylane into speed_up_reconstruct_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements 💯
xdist
, qcut
and qchem
markers, update reconstruct testspytest-xdist
; qcut
and qchem
markers; update reconstruct tests
[sc-17363] |
Context
We aim to lower the runtime of our test suites.
To achieve that, there are further approaches that can be followed up:
pytest
has capabilities for running tests, those can also be utilized.Changes
qcut
qchem
qcut
andqchem
into their own runners;pytest-xdist
to distribute the test runs across 2 cores (-n auto
; GitHub seems to provision 2-core machines);tests/fourier/test_reconstruct.py
frequently runs for almost 1 minute in itself; revisited this file and the test case in specific.Posibble Drawbacks
pytest-xdist
, the separate files are not shown in the log, just dots for the entire suite:Note, that upon a failing test, the file name will be showing nonetheless.