Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qml.QubitUnitary error message in test #144

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Jul 20, 2021

This change was required due to an updated error message in PennyLane core from PennyLaneAI/pennylane#1439

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #144 (6717e23) into master (1e152c7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   99.30%   99.28%   -0.02%     
==========================================
  Files           7        7              
  Lines         287      281       -6     
==========================================
- Hits          285      279       -6     
  Misses          2        2              
Impacted Files Coverage Δ
pennylane_qiskit/qiskit_device.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e152c7...6717e23. Read the comment docs.

@antalszava antalszava requested a review from albi3ro July 20, 2021 09:37
@antalszava antalszava marked this pull request as ready for review July 20, 2021 09:37
@antalszava
Copy link
Contributor Author

[ch7574]

@@ -256,7 +256,6 @@ def apply_operations(self, operations):

mapped_operation = self._operation_map[operation]

self.qubit_unitary_check(operation, par, device_wires)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QubitUnitary check is in PennyLane core -> remove from device

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough :)

@josh146 josh146 merged commit 81502e2 into master Jul 20, 2021
@josh146 josh146 deleted the update_qubit_unitary branch July 20, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants