Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete references to the removed QubitStateVector class #985

Merged
merged 13 commits into from
Nov 14, 2024

Conversation

andrijapau
Copy link
Contributor

Context:

Completing the deprecation cycle of QubitStateVector (see PennyLaneAI/pennylane#6525)

Description of the Change:

Removed all references to the deprecated source code.

[sc-77482]

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions regarding the tests, see what you think :)

mpitests/test_adjoint_jacobian.py Outdated Show resolved Hide resolved
mpitests/test_adjoint_jacobian.py Show resolved Hide resolved
@andrijapau andrijapau marked this pull request as ready for review November 7, 2024 15:42
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (94577a8) to head (093413b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (94577a8) and HEAD (093413b). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (94577a8) HEAD (093413b)
38 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   97.75%   91.86%   -5.89%     
==========================================
  Files         231      179      -52     
  Lines       36712    24858   -11854     
==========================================
- Hits        35886    22835   -13051     
- Misses        826     2023    +1197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your nice work. Could you please check your PR formatting?
Also, please fill out the changelog. 🙂

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@albi3ro
Copy link
Contributor

albi3ro commented Nov 11, 2024

Looking over the indirect changes on code cov, I think codecov is just misbehaving as it sometimes does. We can try just rerunning the CI and seeing if that fixes it, and if not, we could even potentially override.

It makes it look like we've removed All lightning tensor device tests somehow. Initializing lightning.tensor is somehow no longer covered. Which seems wrong. So I would say codecov is just being wonky in this case.

@andrijapau andrijapau merged commit d473c61 into master Nov 14, 2024
91 of 92 checks passed
@andrijapau andrijapau deleted the remove-qubit-state-vector branch November 14, 2024 20:04
andrijapau added a commit to PennyLaneAI/pennylane that referenced this pull request Nov 14, 2024
**Context:**

Completing the deprecation cycle of `QubitStateVector`.

**Description of the Change:**

1. Update `deprecations.rst`
2. Update `changelog-dev.md`
3. Remove all deprecated source code

Also, updated CI to install *latest* `pennylane-qiskit` rather than
stable.

References found in,
- Catalyst:  PennyLaneAI/catalyst#1289
- Lightning: PennyLaneAI/pennylane-lightning#985
- AQT: PennyLaneAI/pennylane-aqt#77
- Qulacs: PennyLaneAI/pennylane-qulacs#83
- Qiskit: PennyLaneAI/pennylane-qiskit#601
- Cirq: PennyLaneAI/pennylane-cirq#203

No references found in,
- QML


[sc-77482]

---------

Co-authored-by: Mudit Pandey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants