This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Kokkos/sv gates #26
Merged
Kokkos/sv gates #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmr
changed the base branch from
feature/native_spmv
to
bugfix/multiqubitop
mlxd
reviewed
Aug 8, 2023
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Outdated
Show resolved
Hide resolved
...e_lightning/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Generator.cpp
Show resolved
Hide resolved
| @@ -75,7 +75,7 @@ TEMPLATE_TEST_CASE("StateVectorKokkos::applyHadamard", | |||
| SECTION("Apply directly") { | |||
There was a problem hiding this comment.
These are no longer falling under the Apply directly signature, since we dynamically look them up. Same with above changes.
There was a problem hiding this comment.
Good point, we can remove a lot of fat here.
There was a problem hiding this comment.
Once all of these are updated to reflect that we no longer do direct applications, or the gate kernels are directly called in place, I am happy to accept.
...ylane_lightning/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Param.cpp
Outdated
Show resolved
Hide resolved
vincentmr
force-pushed
the
bugfix/multiqubitop
branch
from
6e24355
to
088f66d
Compare
vincentmr
force-pushed
the
kokkos/sv_gates
branch
from
ce1d6f2
to
daeb04c
Compare
pennylane_lightning/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Show resolved
Hide resolved
AmintorDusko
approved these changes
Aug 14, 2023
mlxd
approved these changes
Aug 14, 2023
vincentmr
added a commit
that referenced
this pull request
Aug 15, 2023
* Fix bug where functor attributes are used as local variables, causing issues in parallel for loop. * Bring LKokkos AdjJac in line with LQubit's. (#27) * Bring LKokkos AdjJac in line with LQubit's. * Remove obsolete comment. --------- Co-authored-by: Amintor Dusko <[email protected]> * Kokkos/sv gates (#26) * Replace gates_ in LKokkos. * Replace generators_ attribute in LKokkos. * Remove all (except multiRZ) specialized methods from SV-LKokkos. * Refactor LKokkos C++ tests not to use specialized apply methods. * Reorganize StateVectorKokkos.hpp. Use base class getNumQubits and getLength. * Add docstring for gate registering methods and map => unordered_map. * Remove duplicate/obsolete apply-directly tests. * Use std::size_t in LKokkos files. --------- Co-authored-by: Amintor Dusko <[email protected]> * Modify multiQubitOp to handle device kernels correclty. --------- Co-authored-by: Amintor Dusko <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In StateVectorKokkos, replace
gates_andgenerators_attributes by maps generated from the baseGateOperationandGeneratorOperationenums. This improves the readability of the main StateVectorKokkos constructor and removes about 700 lines of specialized methods.