-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Sources
for outputs with BIDS URIs
#966
Conversation
Sources
for some outputs with BIDS URIs
The concatenated atlas-wise sources aren't right. Instead of selecting the appropriate atlas's element in the run-wise lists of sources, it's just keeping the full run-wise lists. |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
@mattcieslak would you mind reviewing this with an eye toward streamlining the code? I'm sure I'll be able to improve it over time, but if there's anything obvious that I'm missing it would be great to catch it before I merge the PR. |
Whoops, looks like the add-coverage-to-sources step is overwriting the sources without retaining the old ones. I'll need to figure out what went wrong with my recent changes before merging. EDIT: Fixed! |
Sources
for some outputs with BIDS URIsSources
for outputs with BIDS URIs
Closes #568.
Breaking changes
fd_thresh
is <= 0 (i.e., censoring is disabled).params
is None (i.e., denoising is disabled).Changes proposed in this pull request
Sources
field.DatasetLinks
field to dataset description file. The links are to the preprocessed data, the XCP-D derivatives, and (optionally) the custom confounds._make_uri
: General path-resolving function._make_xcpd_uri
: Resolves path for XCP-D derivative files._make_xcpd_uri_lol
: Resolves path for XCP-D derivative files organized in lists of lists.._make_preproc_uri
: Resolves path for preprocessing pipeline derivative files._make_custom_uri
: Resolves path for custom confounds files.Sources
field in workflows._listify
: From NiMARE. Convert things to lists._make_dictionary
: Feed kwargs into a dictionary. I use this to create metadata dictionaries containingSources
fields to pass intoDerivativesDataSinks
. The issue is thatMapNodes
need to reference fields in the.inputs
attribute of the underlying interface, butDerivativesDataSinks
don't includeSources
as a field in.inputs
. However, they do includemeta_dict
, so I need to pass in ameta_dict
containing theSources
field instead of passing inSources
directly._transpose_lol
: Transposes a list of lists. Used in_make_xcpd_uri_lol
.