Slider n arrows #170
Slider n arrows #170
Conversation
…age refresh again.
| function untraceLine(lineIndex) { | ||
| var line = traceEvents[lineIndex].location.first_line; | ||
| var prevLine = -1; | ||
| var block_mode = true; |
There was a problem hiding this comment.
var block_mode = view.getPaneEditorBlockMode(view.paneid("left"));
Right? If there's a possibility that getPaneEditor... might return something other that true or false, and you care that block_mode only be true or false, then use !! (not of not of). But here it looks like you only test the truthiness, so my version is correct and simpler to understand.
There was a problem hiding this comment.
I don't understand this comment. What do you want me to write? Grabbing the block editor either returns the editor (in which case if (block_mode) is true) or returns nothing (then it's false). What's hard to understand about it?
|
Hey @bobcassels, thanks for reviewing! Sorry it isn't more clear but pencil-tracer.js is actually generated code, from CoffeeScript source (which is at https://github.com/yjerem/pencil-tracer). That's why there are some weird variable names and patterns in that file (unfortunately the CoffeeScript compiler otherwise generates code that looks human-written...). Actually, I will try and get pencil-tracer pulled in as an npm package to be browserified, like pencilcode's other dependencies. |
…ated, and fixed a few spacing issues
…text mode scroll or the cut off in droplet. Looking for other ways to solve this problem
| }; | ||
|
|
||
| function getClosestHandle( val ) { | ||
|
|
There was a problem hiding this comment.
What's a handle? and if it's the thing you drag around, why/when are there several?
(I may or may not go through and leave a bunch more comments on the slider code, just for reference)
There was a problem hiding this comment.
Hey Yana, thanks for commenting! This isn't my code, it's part of the jquery-ui-slider-pips library that I use to help create the slider. You have the possibility of multiple handles on a slider with this library (I only used one handle). To clarify, the handle is the thing that you drag around on the slider.
Hi David,
This isn't ready to be merged, but I included both my code and Cali's code in this pr so we don't leave everything to the last minute. It's going to fail the javascript code test, but we know why. I added a separate protractor.js file as a possible solution to having messy code because of circular dependencies. If you think I should use protractor.js in debug.js and view.js, let me know. Thanks!