Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Event Handling for AlwaysAuthenticate Keys with operation-pin Event #312

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

microshine
Copy link
Contributor

Description

This pull request focuses on implementing functionality related to handling events when using keys that require AlwaysAuthenticate. A new event type, operation-pin, has been introduced. The structure of this event can be seen in the SubtleAlwaysAuthenticateEvent interface:

export interface SubtleAlwaysAuthenticateEvent extends ServiceNotifyEvent {
  type: "operation-pin";
  origin: string;
  label: string;
  keyLabel: string;
  operation: string;
  resolve: (pin: AlwaysAuthenticateHandleResult) => void;
  reject: (error: Error) => void;
}

@microshine microshine merged commit e67a34b into master Oct 11, 2024
2 checks passed
@microshine microshine deleted the always-authenticate branch October 11, 2024 13:05
Copy link

NPM package v1.10.7 has been published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant