Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded asn1js to version 2 #56

Merged
merged 7 commits into from
Mar 26, 2017
Merged

Conversation

fotisl
Copy link
Contributor

@fotisl fotisl commented Mar 23, 2017

Upgraded asn1js to version 2. Furthermore, official typings for asn1js have been used. This allows usage of pkijs version 2 too.

@rmhrisk
Copy link
Contributor

rmhrisk commented Mar 23, 2017

OMG

@fotisl
Copy link
Contributor Author

fotisl commented Mar 23, 2017

I hope this is an OMG in a good and not bad sense :)

@fotisl
Copy link
Contributor Author

fotisl commented Mar 26, 2017

All problems fixed, @rmhrisk you can now merge.

@fotisl
Copy link
Contributor Author

fotisl commented Mar 26, 2017

In addition, I believe this closes #33. Issue #34 should also be closed since we moved from typings to @types.

@rmhrisk rmhrisk merged commit 20ba413 into PeculiarVentures:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants