Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find fqdn across platforms #3058

Merged
merged 4 commits into from
Oct 21, 2022
Merged

find fqdn across platforms #3058

merged 4 commits into from
Oct 21, 2022

Conversation

dlebauer
Copy link
Member

@dlebauer dlebauer commented Oct 20, 2022

Description

Add as.character(Sys.info()["nodename"]) if no env variable FQDN and hostname -f return empty strings.

Motivation and Context

hostname doesn't work on Windows. Fixes #3044

Perhaps a simpler option

replace function with fqdn <- function() as.character(Sys.info()["nodename"])

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

base/remote/R/fqdn.R Outdated Show resolved Hide resolved
base/remote/R/fqdn.R Outdated Show resolved Hide resolved
@dlebauer dlebauer changed the title add third option for finding fqdn find fqdn across platforms Oct 20, 2022
@robkooper robkooper merged commit 0ff670e into develop Oct 21, 2022
@robkooper robkooper deleted the fqdn2 branch October 21, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing windows build of PEcAn.ED2: bug in fqdn()?
2 participants