Empty map in strict mode does not throw exception (#491) (#492)

PebbleTemplates · Dec 18, 2019 · 33e8b43 · 33e8b43
1 parent ca9ebdc
commit 33e8b43
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/pebble/src/main/java/com/mitchellbosecke/pebble/attributes/MapResolver.java b/pebble/src/main/java/com/mitchellbosecke/pebble/attributes/MapResolver.java
@@ -4,6 +4,7 @@
 import com.mitchellbosecke.pebble.error.PebbleException;
 import com.mitchellbosecke.pebble.node.ArgumentsNode;
 import com.mitchellbosecke.pebble.template.EvaluationContextImpl;
+
 import java.util.Map;
 
 class MapResolver implements AttributeResolver {
@@ -22,7 +23,7 @@ public ResolvedAttribute resolve(Object instance,
       String filename,
       int lineNumber) {
     Map<?, ?> object = (Map<?, ?>) instance;
-    if (object.isEmpty()) {
+    if (object.isEmpty() && !context.isStrictVariables()) {
       return new ResolvedAttribute(null);
     }
 

diff --git a/pebble/src/test/java/com/mitchellbosecke/pebble/GetAttributeTest.java b/pebble/src/test/java/com/mitchellbosecke/pebble/GetAttributeTest.java
@@ -142,6 +142,23 @@ void testNonExistingMapAttributeWithStrictVariables() throws PebbleException, IO
     });
   }
 
+  @Test
+  void testNonExistingMapAttributeWithStrictVariablesAndEmptyMap() throws PebbleException, IOException {
+    assertThrows(AttributeNotFoundException.class, () -> {
+      PebbleEngine pebble = new PebbleEngine.Builder().loader(new StringLoader())
+          .strictVariables(true).build();
+
+      String source = "{{ object.nonExisting }}";
+      PebbleTemplate template = pebble.getTemplate(source);
+
+      Map<String, Object> context = new HashMap<>();
+      context.put("object", new HashMap<>());
+
+      Writer writer = new StringWriter();
+      template.evaluate(writer, context);
+    });
+  }
+
   @Test
   void testNullMapValueWithoutStrictVariables() throws PebbleException, IOException {
     PebbleEngine pebble = new PebbleEngine.Builder().loader(new StringLoader())